enchant: Add a TODO with preliminary analysis of `rm -rf /' problem

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Module Name:	pkgsrc-wip
Committed By:	Leonardo Taccari <leot%NetBSD.org@localhost>
Pushed By:	leot
Date:		Fri Oct 26 12:43:28 2018 +0200
Changeset:	6f93281ab19ee21ed9526cd3a7fa663498ebdd6b

Added Files:
	enchant/TODO

Log Message:
enchant: Add a TODO with preliminary analysis of `rm -rf /' problem

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=6f93281ab19ee21ed9526cd3a7fa663498ebdd6b

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 enchant/TODO | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diffs:
diff --git a/enchant/TODO b/enchant/TODO
new file mode 100644
index 0000000000..baa2a71eaa
--- /dev/null
+++ b/enchant/TODO
@@ -0,0 +1,23 @@
+Running the test target can lead to a `rm -rf /'!:
+
+ |    /usr/bin/make libenchant-copy
+ |    rm -rf /
+
+All `rm -rf' incantantions should be inspected.
+After a quick skim of the code it seems that, in tests/Makefile.am:
+
+    35  libenchant-copy:
+    36          rm -rf $(libdir_subdir)/
+    37          $(MKDIR_P) $(libdir_subdir)/enchant-@ENCHANT_MAJOR_VERSION@
+    38          cp -r $(top_builddir)/src/@objdir@ $(libdir_subdir)/
+    39          cp $(top_builddir)/src/libenchant-@ENCHANT_MAJOR_VERSION@.la $(libdir_subdir)/
+
+...and in tests/enchant_providers/Makefile.am
+
+    30  libenchant-copy:
+    31          rm -rf $(libdir_subdir)/
+    32          $(MKDIR_P) $(libdir_subdir)/enchant-@ENCHANT_MAJOR_VERSION@
+    33          cp -r $(top_builddir)/src/@objdir@ $(libdir_subdir)/
+    34          cp $(top_builddir)/src/libenchant-@ENCHANT_MAJOR_VERSION@.la $(libdir_subdir)/
+
+Both `rm -rf' can be problematic if $(libdir_subdir) is not defined.