pkgsrc-WIP-changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

midori: Append to CONFIGURE_ENV instead of redefining it (NFCI)



Module Name:	pkgsrc-wip
Committed By:	Leonardo Taccari <leot%NetBSD.org@localhost>
Pushed By:	leot
Date:		Sun Dec 9 17:19:08 2018 +0100
Changeset:	e3a8a58769277ccb4f3de575e22483afc1a4ba71

Modified Files:
	midori/Makefile

Log Message:
midori: Append to CONFIGURE_ENV instead of redefining it (NFCI)

This is not a functional change in that case but the latter is more prone to
possible (accidental) error.

(Unrelated but interesting side-note: VALAC is exported via vala bl3 when
GNU_CONFIGURE is set... I think that it is better to not extend it though,
probably midori is just an exception that reuses it and we can just pass it
through CONFIGURE_ENV)

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=e3a8a58769277ccb4f3de575e22483afc1a4ba71

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 midori/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diffs:
diff --git a/midori/Makefile b/midori/Makefile
index 66c18d7794..8ac93dd6c1 100644
--- a/midori/Makefile
+++ b/midori/Makefile
@@ -17,7 +17,7 @@ USE_TOOLS+=	intltool msgfmt pkg-config
 
 BUILDLINK_TRANSFORM+=	rm:-Werror
 
-CONFIGURE_ENV=	VALAC=${VALAC}
+CONFIGURE_ENV+=	VALAC=${VALAC}
 
 .include "../../databases/sqlite3/buildlink3.mk"
 .include "../../devel/gettext-lib/buildlink3.mk"


Home | Main Index | Thread Index | Old Index