Re: "New package" - muparser, update to 2.2.6

[voidpin <voidpin%protonmail.com@localhost>]

I've e-mailed @jperkin and asked, he applied the patches.

As far as I understood, to build on Solaris.

As I wrote, I only needed it as a build dependency and have
no experience with muparser.
I'd suggest waiting for @jperkin before importing, I'd guess he
knows what to do.

Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Wednesday, January 8, 2020 3:03 PM, Leonardo Taccari leot%NetBSD.org@localhost wrote:

> Hello pin,
> Thanks! Some possible comments/changes suggested directly inline!
> pin writes:
>
> > [...]
> > Log Message:
> > "New package" - muparser, update to 2.2.6
> > Update muparser to 2.2.6
> > The version in pkgsrc is 200.2.2.2
> > The project moved from SourceForge to Github in 2016.
> > Package builds and installs without the patches applied
> > on the pkgsrc version.
> > Please review the need or, not of these patches.
> > [...]
>
> Does that mean that the patch were applied upstream? (e.g. unportable
> `==' could accidentally works on some platforms but not others)
> If that's the case it's better to keep them to be on the safer side.
>
> > --- /dev/null
> > +++ b/muparser/Makefile
> > @@ -0,0 +1,28 @@
> > +# $NetBSD$
> > +
> > +GITHUB_PROJECT= muparser
> > +GITHUB_TAG= v2.2.6.1
> > +DISTNAME= v2.2.6.1
> > +PKGNAME= ${GITHUB_PROJECT}-${DISTNAME:S,^v,,}
> > +CATEGORIES= math
> > +MASTER_SITES= ${MASTER_SITE_GITHUB:=beltoforion/}
> > +DIST_SUBDIR= ${GITHUB_PROJECT}
> > +
>
> Please simplify that to:
> DISTNAME= muparser-2.2.6.1
> CATEGORIES= math
> MASTER_SITES= ${MASTER_SITE_GITHUB:=beltoforion/}
> GITHUB_TAG= v${PKGVERSION_NOREV}
> After you have done these changes a `make makesum' will be also needed.
>
> > [...]
> > +WRKSRC= ${WRKDIR}/muparser-2.2.6.1
> > [...]
>
> After the above semplification you can safetely remove WRKSRC because
> it's already `${WRKDIR}/${DISTNAME}' by default.
>
> > +MAKE_JOBS_SAFE= no
>
> Any idea why it's not MAKE_JOBS_SAFE? If yes please add a rationale
> regarding that! (I see that's already present in math/muparser, but it
> would be nice to add a comment/rationale regarding that)
> Thank you!