pkgsrc-WIP-changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

openblas: flags from environment again to un-break PICy build



Module Name:	pkgsrc-wip
Committed By:	Dr. Thomas Orgis <thomas.orgis%uni-hamburg.de@localhost>
Pushed By:	thor
Date:		Wed Feb 24 18:40:17 2021 +0100
Changeset:	056e3d5c972a4b286e8755dbee323a9951855165

Modified Files:
	openblas/Makefile.common

Log Message:
openblas: flags from environment again to un-break PICy build

The bug that prompted us to force the compiler flags in the
make arguments is fixed. Now we got a different one: The logic
that decides to add -fPIC where needed is overridden when doing
this, resulting in relocation errors (strangely, not with every
toolchain).

So let's remove that again and take FFLAGS and friends from the
environment again.

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=056e3d5c972a4b286e8755dbee323a9951855165

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 openblas/Makefile.common | 5 -----
 1 file changed, 5 deletions(-)

diffs:
diff --git a/openblas/Makefile.common b/openblas/Makefile.common
index b92eddd5db..b8f69bfbfe 100644
--- a/openblas/Makefile.common
+++ b/openblas/Makefile.common
@@ -39,11 +39,6 @@ NO_CONFIGURE=	yes
 
 TEST_TARGET=	tests
 
-# Work around CFLAGS breakage:
-# https://github.com/xianyi/OpenBLAS/issues/818
-MAKE_FLAGS+=	CFLAGS=${CFLAGS:Q}
-MAKE_FLAGS+=	CXXFLAGS=${CXXFLAGS:Q}
-MAKE_FLAGS+=	FFLAGS=${FFLAGS:Q}
 # Also set compilers explicitly, overriding Makefile.rule
 MAKE_FLAGS+=	CC=${CC:Q}
 MAKE_FLAGS+=	CXX=${CXX:Q}


Home | Main Index | Thread Index | Old Index