pkgsrc-WIP-changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

unit-php: Stub out use of command at makefile eval time



Module Name:	pkgsrc-wip
Committed By:	Greg Troxel <gdt%lexort.com@localhost>
Pushed By:	gdt
Date:		Tue Feb 15 11:44:29 2022 -0500
Changeset:	0dd43c160b01830fcc66442a8a1cfcd70c1570a6

Modified Files:
	unit-php/Makefile

Log Message:
unit-php: Stub out use of command at makefile eval time

It's not ok to run a command when evaluating the makefile.  Simply
stub it out and stick in BROKEN always for now.

There is an idiom for testing if another package would be built with a
particular option, and that should be used instead.

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=0dd43c160b01830fcc66442a8a1cfcd70c1570a6

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 unit-php/Makefile | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diffs:
diff --git a/unit-php/Makefile b/unit-php/Makefile
index 93f489e031..a2d109d01f 100644
--- a/unit-php/Makefile
+++ b/unit-php/Makefile
@@ -12,10 +12,12 @@ PHP_VERSIONS_ACCEPTED?=	56 73 74 80
 
 .include "../../lang/php/phpversion.mk"
 
-PHP_BUILD_OPTIONS!=	${RUN} ${PKG_INFO} -Bn php | ${GREP} PKG_OPTIONS
-.if empty(PHP_BUILD_OPTIONS:Mphp-embed)
-BROKEN=		"Requires the php-embed option enabled in PHP."
-.endif
+#PHP_BUILD_OPTIONS!=	${RUN} ${PKG_INFO} -Bn php | ${GREP} PKG_OPTIONS
+#.if empty(PHP_BUILD_OPTIONS:Mphp-embed)
+#BROKEN=		"Requires the php-embed option enabled in PHP."
+#.endif
+
+BROKEN=		"Requires the php-embed option enabled in PHP but there is no code to check if this is so."
 
 post-configure:
 	${RUN} cd ${WRKSRC} && ${SETENV} ${_CONFIGURE_SCRIPT_ENV}	\


Home | Main Index | Thread Index | Old Index