ags: update to ags-3.5.1.19

[Yorick Hardy <yorickhardy%gmail.com@localhost>]

Module Name:	pkgsrc-wip
Committed By:	Yorick Hardy <yorickhardy%gmail.com@localhost>
Pushed By:	yhardy
Date:		Sun Jul 17 22:20:08 2022 +0200
Changeset:	dbaf644b6d2a779537b60c68a9a08efb13bfbd2f

Modified Files:
	ags/Makefile
	ags/distinfo
Added Files:
	ags/patches/patch-Engine_media_audio_sound.cpp

Log Message:
ags: update to ags-3.5.1.19

VERSION 3.5.1 - Patch 12, June 2022

Engine:
 - Fixed GUI textual controls don't redraw when the game translation changes until player clicks
   on GUI (regression since previous 3.5.1 updates).
 - Fixed multitasking mode persisting if the game was switched from windowed to fullscreen mode
   (even though it's not supposed to work in fullscreen).

VERSION 3.5.1 - Patch 11, May 2022

Editor:
 - Fixed batch sprite export with "Set exported file as sprite source" option was assigning
   new source paths without file extension.

Engine:
 - Perfomance fix: GUIs changing Transparency or Visible state should not redraw their surface.

Compatibility:
 - Allow AudioClip.Play to to place clips on a crossfade channel, which is normally unaccessible
   from script. This prevents errors in some games that relied on this behavior.

VERSION 3.5.1 - Patch 10, April 2022

Engine:
 - Fixed crash when visible viewport does not have any linked camera.
 - Fixed ListBox.FillSaveGameList() may include save slots with negative slot number (e.g. when
   the save file has "*.-01" extension).
 - Fixed potential crash after failed RunAGSGame() call.
 - Fixed search for the game data by GUID when restoring a save belonging to another game;
   this was implemented in 3.5.1, but appeared to not work correctly.

VERSION 3.5.1 - Patch 9, March 2022

Editor:
 - Removed restriction on max dialog topics in the project. The dialog limit in the engine was
   removed in 3.4.1, but remained in the Editor by oversight.
 - Fixed Audio Clip items in the project tree not displaying their IDs right after being renamed.

Compiler:
 - Fixed crash occuring when compiler tries to report "Already referenced name as import" error.

Engine:
 - Added "--translation" and "--no-translation" command-line arguments.

VERSION 3.5.1 - Patch 8, Ferbuary 2022

Engine:
 - Clearer error messages for Get/SetProperty functions.
 - Fixed PlayFlic() command fails to start the video (regression in 3.5.1).
 - Fixed DrawingSurface.DrawSurface() not applying transparency parameter correctly if the
   drawn surface has alpha channel.
 - Fixed @OVERHOTSPOT@ is not updated immediately when character's name changes while cursor
   is above that character.

VERSION 3.5.1 - Patch 7, January 2022

Editor:
 - Added "Layout -> Reset to Defaults" menu command.
 - Editor will now reset panel layout to default state if loading layout fail for any reason.
 - Default config is now saved also when the game is run in debug mode (F5). This ensures that
   the test run is using the latest Default Setup, if the user's config has not been created yet.
 - Editor will now display an error if user tried to reserve too many channels for audio types.
 - Fixed Editor failing to start if user preferences file is corrupted.
 - Fixed "Use old-style custom dialog options API" was not set when importing pre-3.4.0 projects.
 - Fixed comboboxes' drop-down arrows were not painted with the right color from a color theme.

Engine:
 - Fixed program crash occuring if the game reserved too many channels for audio types.
 - Fixed potential crash occuring when player loads a save made in a multi-frame room, but the room
   was since edited and no longer has as many frames.
 - Fixed character may have incorrect Frame property values while turning.

VERSION 3.5.1 - Patch 6, December 2021

Editor:
 - Added line numbers in the dialog script editor.
 - Fixed Dialog script loosing changes if the pane is closed or redocked.
 - Fixed controls arrangement on the Dialog pane getting broken when it's redocked.

Engine:
 - Fixed filepaths in scripts that have backslashes ('\') fail on non-Windows systems.
   All the File functions will now convert backslashes in filepaths into forward
   slashes for compatibility.
 - Fixed engine was still creating standard directories for game saves and data, even
   if user provided the custom paths for these.
 - Fixed TextBox control crashing the game if it's empty and player presses Backspace.
 - Fixed controls on a fully transparent GUI were not interactive (this is an original
   AGS behavior, which was unintentionally changed in 3.5.0 by mistake).

Compatibility:
 - When running 3.5.0 games, treat fully transparent GUI as non-interactable.
   In AGS transparent GUIs may be still interacted with, but 3.5.0 introduced an
   unintentional (and undocumented) change to this, which was reverted in 3.5.1.

Android:
 - Support global engine's config file when the game is run from the Launcher: it's
   located in the AGS games' parent directory, same place where android.cfg is.

WinSetup:
 - Added "Custom game shared data path" to complement "Custom save path" option.

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=dbaf644b6d2a779537b60c68a9a08efb13bfbd2f

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 ags/Makefile                                   |  5 ++---
 ags/distinfo                                   |  7 ++++---
 ags/patches/patch-Engine_media_audio_sound.cpp | 18 ++++++++++++++++++
 3 files changed, 24 insertions(+), 6 deletions(-)

diffs:
diff --git a/ags/Makefile b/ags/Makefile
index f5496047ef..d1837262e8 100644
--- a/ags/Makefile
+++ b/ags/Makefile
@@ -1,6 +1,6 @@
 # $NetBSD: Makefile,v 1.2 2015/09/14 22:26:14 yhardy Exp $
 
-DISTNAME=	ags-3.5.1.11
+DISTNAME=	ags-3.5.1.19
 CATEGORIES=	games
 MASTER_SITES=	${MASTER_SITE_GITHUB:=adventuregamestudio/}
 GITHUB_TAG=	v.${PKGVERSION_NOREV}
@@ -15,8 +15,7 @@ USE_LANGUAGES=	c c++
 
 USE_TOOLS+=	gmake pkg-config
 
-do-build:
-	cd ${WRKSRC} && ${MAKE_PROGRAM} --directory=Engine
+BUILD_DIRS=	Engine
 
 INSTALLATION_DIRS+=	bin
 INSTALLATION_DIRS+=	share/doc/ags
diff --git a/ags/distinfo b/ags/distinfo
index 320ed8d63e..2d320a0846 100644
--- a/ags/distinfo
+++ b/ags/distinfo
@@ -1,9 +1,10 @@
 $NetBSD$
 
-RMD160 (ags-3.5.1.11.tar.gz) = 90cc9b75e4304c67f986695e1f4cf1910ead8eef
-SHA512 (ags-3.5.1.11.tar.gz) = 1330c376f2c6645feaf2473fb6a8b537828a38955fb2bd41aae29f0e29038f8279db3d91939c7da90772fac0327e34d8a53a95ea931c9beaee62b51d3ce92494
-Size (ags-3.5.1.11.tar.gz) = 7638521 bytes
+BLAKE2s (ags-3.5.1.19.tar.gz) = 9125ca2426d586b65947b511876f209253480cc672f0f63dd5793b9372f293ab
+SHA512 (ags-3.5.1.19.tar.gz) = 408f348c5f9fee617676de925809f638e84de3a334cf60de550dd95e883a324b60c6a2e01dfeb7245612e97ab736d537f43eba962fa0217a001e26031237f655
+Size (ags-3.5.1.19.tar.gz) = 7640653 bytes
 SHA1 (patch-Common_core_platform.h) = 393ae8b7e90601cfab0b11ecb185693db6a24ee1
 SHA1 (patch-Engine_Makefile) = 849759ce98a4e4cdb5bf2d1ebb961295169ab170
 SHA1 (patch-Engine_Makefile-defs.linux) = f283deedc28ca4c720cad52579f849668e86a30c
 SHA1 (patch-Engine_libsrc_libcda-0.5_linux.c) = f4f2bd480b36c1c47aa724b29b620b27a4ad392b
+SHA1 (patch-Engine_media_audio_sound.cpp) = 7820e80f8b601ed4fd809b9d2348dfe1710c4e5a
diff --git a/ags/patches/patch-Engine_media_audio_sound.cpp b/ags/patches/patch-Engine_media_audio_sound.cpp
new file mode 100644
index 0000000000..2e06648c92
--- /dev/null
+++ b/ags/patches/patch-Engine_media_audio_sound.cpp
@@ -0,0 +1,18 @@
+$NetBSD$
+
+dump_read_mod requires an extra parameter, "int restrict_", set it to 0
+which means "no restrictions"; explained at:
+
+  https://github.com/kode54/dumb/issues/53
+
+--- Engine/media/audio/sound.cpp.orig	2021-12-28 18:32:51.000000000 +0000
++++ Engine/media/audio/sound.cpp
+@@ -331,7 +331,7 @@ SOUNDCLIP *my_load_mod(const AssetPath &
+         modPtr = dumb_read_s3m(df);
+     }
+     else if (charAfterDot == 'M') {
+-        modPtr = dumb_read_mod(df);
++        modPtr = dumb_read_mod(df, 0);
+     }
+ 
+     dumbfile_close(df);