ppsspp: fix build and update PLIST

[Thomas Klausner <wiz%NetBSD.org@localhost>]

Module Name:	pkgsrc-wip
Committed By:	Thomas Klausner <wiz%NetBSD.org@localhost>
Pushed By:	wiz
Date:		Thu Mar 14 09:05:18 2024 +0100
Changeset:	735e3711896085af073a5ef0061560eb68674a3e

Modified Files:
	ppsspp/Makefile
	ppsspp/PLIST

Log Message:
ppsspp: fix build and update PLIST

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=735e3711896085af073a5ef0061560eb68674a3e

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 ppsspp/Makefile | 19 ++++++++++++++-----
 ppsspp/PLIST    |  4 ----
 2 files changed, 14 insertions(+), 9 deletions(-)

diffs:
diff --git a/ppsspp/Makefile b/ppsspp/Makefile
index 5d3673a357..e4d904fcdd 100644
--- a/ppsspp/Makefile
+++ b/ppsspp/Makefile
@@ -11,15 +11,16 @@ HOMEPAGE=	https://www.ppsspp.org/
 COMMENT=	PSP emulator
 LICENSE=	gnu-gpl-v2
 
-USE_CMAKE=	yes
-USE_LANGUAGES=	c c++17
-USE_TOOLS+=	pkg-config
-.include "../../lang/python/tool.mk"
-
 # There's a crash that consistently happens whenever PPSSPPSDL exits, but
 # only when built with GCC. Works fine with Clang, though.
 BUILD_DEPENDS+=	clang-[0-9]*:../../lang/clang
 
+USE_LANGUAGES=		c c++
+USE_CXX_FEATURES=	c++17
+USE_TOOLS+=		pkg-config
+
+CFLAGS+=		-fPIE
+
 ONLY_FOR_PLATFORM=	*-*-*arm* *-*-x86_64 *-*-i386
 
 CMAKE_ARGS+=	-DCMAKE_C_COMPILER=${CLANGBASE:Q}/bin/clang
@@ -36,7 +37,14 @@ CMAKE_ARGS+=	-DUSE_SYSTEM_ZSTD=ON
 NOT_PAX_ASLR_SAFE+=	bin/PPSSPPSDL
 NOT_PAX_MPROTECT_SAFE+=	bin/PPSSPPSDL
 
+.include "../../mk/bsd.prefs.mk"
+# wiz 20240314:
+# the ninja generator has problems in some environments:
+# ninja: error: manifest 'build.ninja' still dirty after 100 tries, perhaps system time is not set
+CMAKE_GENERATOR=	make
 .include "../../mk/compiler/clang.mk"
+.include "../../devel/cmake/build.mk"
+.include "../../lang/python/tool.mk"
 .include "../../archivers/libzip/buildlink3.mk"
 .include "../../archivers/zstd/buildlink3.mk"
 .include "../../devel/SDL2/buildlink3.mk"
@@ -44,6 +52,7 @@ NOT_PAX_MPROTECT_SAFE+=	bin/PPSSPPSDL
 .include "../../devel/zlib/buildlink3.mk"
 .include "../../graphics/glew/buildlink3.mk"
 .include "../../graphics/png/buildlink3.mk"
+.include "../../graphics/hicolor-icon-theme/buildlink3.mk"
 .include "../../multimedia/ffmpeg3/buildlink3.mk"
 .include "../../net/miniupnpc/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git a/ppsspp/PLIST b/ppsspp/PLIST
index c5e59d9d4f..3b3f86ee59 100644
--- a/ppsspp/PLIST
+++ b/ppsspp/PLIST
@@ -17,7 +17,6 @@ share/ppsspp/assets/Roboto-Condensed.ttf
 share/ppsspp/assets/asciifont_atlas.meta
 share/ppsspp/assets/asciifont_atlas.zim
 share/ppsspp/assets/compat.ini
-share/ppsspp/assets/compatvr.ini
 share/ppsspp/assets/debugger/.nojekyll
 share/ppsspp/assets/debugger/asset-manifest.json
 share/ppsspp/assets/debugger/favicon.ico
@@ -51,7 +50,6 @@ share/ppsspp/assets/font_atlas.meta
 share/ppsspp/assets/font_atlas.zim
 share/ppsspp/assets/gamecontrollerdb.txt
 share/ppsspp/assets/icon_regular_72.png
-share/ppsspp/assets/knownfuncs.ini
 share/ppsspp/assets/lang/ar_AE.ini
 share/ppsspp/assets/lang/az_AZ.ini
 share/ppsspp/assets/lang/bg_BG.ini
@@ -100,10 +98,8 @@ share/ppsspp/assets/logo.png
 share/ppsspp/assets/ppge_atlas.meta
 share/ppsspp/assets/ppge_atlas.zim
 share/ppsspp/assets/rargray.png
-share/ppsspp/assets/sfx_achievement_unlocked.wav
 share/ppsspp/assets/sfx_back.wav
 share/ppsspp/assets/sfx_confirm.wav
-share/ppsspp/assets/sfx_leaderbord_submitted.wav
 share/ppsspp/assets/sfx_select.wav
 share/ppsspp/assets/sfx_toggle_off.wav
 share/ppsspp/assets/sfx_toggle_on.wav