davegnukem: Minor tweaks to use best practices.

[Simon Howard <fraggle%soulsphere.org@localhost>]

Module Name:	pkgsrc-wip
Committed By:	Simon Howard <fraggle%soulsphere.org@localhost>
Pushed By:	fraggle
Date:		Sun Apr 28 22:57:29 2024 -0400
Changeset:	7e155ce5e5b90f5dea61ae97c45a01be7e263669

Modified Files:
	davegnukem/Makefile
	davegnukem/PLIST

Log Message:
davegnukem: Minor tweaks to use best practices.

We don't need to define our own `V` variable because we can use
PKGVERSION_NOREV which provides the same thing. Also resolve a pkglint
warning about missing NetBSD comment header in PLIST.

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=7e155ce5e5b90f5dea61ae97c45a01be7e263669

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 davegnukem/Makefile | 14 +++++++-------
 davegnukem/PLIST    |  1 +
 2 files changed, 8 insertions(+), 7 deletions(-)

diffs:
diff --git a/davegnukem/Makefile b/davegnukem/Makefile
index 10b36b7759..aa0b20065e 100644
--- a/davegnukem/Makefile
+++ b/davegnukem/Makefile
@@ -1,17 +1,17 @@
 # $NetBSD$
 
-V=1.0.3
-DISTNAME=	davegnukem-${V}
+DISTNAME=	davegnukem-1.0.3
 CATEGORIES=	games
 MASTER_SITES=	${MASTER_SITE_GITHUB:=davidjoffe/}
-GITHUB_TAG=	${V}
+GITHUB_TAG=	${PKGVERSION_NOREV}
 GITHUB_PROJECT=	dave_gnukem
 EXTRACT_USING=	bsdtar
 
 # The game data is distributed as a separate file.
-SITES.davegnukem-data-${V}.tar.gz= \
--https://github.com/davidjoffe/gnukem_data/archive/refs/tags/${V}.tar.gz
-DISTFILES=	${DEFAULT_DISTFILES} davegnukem-data-${V}.tar.gz
+DATA_REPOSITORY=https://github.com/davidjoffe/gnukem_data
+SITES.davegnukem-data-${PKGVERSION_NOREV}.tar.gz= \
+    -${DATA_REPOSITORY}/archive/refs/tags/${PKGVERSION_NOREV}.tar.gz
+DISTFILES=	${DEFAULT_DISTFILES} davegnukem-data-${PKGVERSION_NOREV}.tar.gz
 
 MAINTAINER=	pkgsrc-users%NetBSD.org@localhost
 HOMEPAGE=	https://djoffe.com/gnukem/
@@ -27,7 +27,7 @@ PLIST.bsd=	yes
 
 # The Makefile install step expects to find the data files in data/
 pre-configure:
-	cd ${WRKSRC} && mv ../gnukem_data-${V} data
+	cd ${WRKSRC} && mv ../gnukem_data-${PKGVERSION_NOREV} data
 
 SUBST_CLASSES+=		man
 SUBST_STAGE.man=	pre-configure
diff --git a/davegnukem/PLIST b/davegnukem/PLIST
index f72f068ef3..2edfe839ba 100644
--- a/davegnukem/PLIST
+++ b/davegnukem/PLIST
@@ -1,3 +1,4 @@
+@comment $NetBSD$
 games/davegnukem
 share/applications/davegnukem.desktop
 share/doc/davegnukem-data/README.md