pkgsrc-WIP-changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

ThirdParty_Mumps: pkglint suggested updates



Module Name:	pkgsrc-wip
Committed By:	mayuresh <mayuresh%acm.org@localhost>
Pushed By:	mayuresh
Date:		Mon Aug 26 10:17:46 2024 +0530
Changeset:	2d74fede62d0f173af2ceee06746966728a24006

Modified Files:
	OpenROAD/Makefile
	ThirdParty-Mumps/DESCR
	ThirdParty-Mumps/Makefile

Log Message:
ThirdParty_Mumps: pkglint suggested updates

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=2d74fede62d0f173af2ceee06746966728a24006

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 OpenROAD/Makefile         |  3 +--
 ThirdParty-Mumps/DESCR    | 22 +---------------------
 ThirdParty-Mumps/Makefile | 20 +++++++++-----------
 3 files changed, 11 insertions(+), 34 deletions(-)

diffs:
diff --git a/OpenROAD/Makefile b/OpenROAD/Makefile
index 7dd5bba4f0..0abef469d9 100644
--- a/OpenROAD/Makefile
+++ b/OpenROAD/Makefile
@@ -31,10 +31,9 @@ TOOL_DEPENDS+=  swig4-[0-9]*:../../devel/swig4
 
 SUBST_SED.compiler=	-e 's|g++|'${CXX:Q}'|g'
 
-UNRESOLVED_LIB_DEPS= libcoinmumps.so:math/coin-or-mumps \
+UNRESOLVED_LIB_DEPS= libortools.so:math/or-tools \
 		libcudd.so:math/cudd \
 		libnauty.so:math/nauty \
-		libortools.so:math/or-tools \
 
 .include "../../devel/boost-libs/buildlink3.mk"
 .include "../../devel/abseil/buildlink3.mk"
diff --git a/ThirdParty-Mumps/DESCR b/ThirdParty-Mumps/DESCR
index c8b2bf6143..890dbb4f2b 100644
--- a/ThirdParty-Mumps/DESCR
+++ b/ThirdParty-Mumps/DESCR
@@ -1,23 +1,3 @@
-TODO: Adjust the following lines from README.md
-
-# ThirdParty-Mumps
-
 This is an autotools-based build system to build and install
-[MUltifrontal Massively Parallel sparse direct Solver](http://mumps-solver.org/) (MUMPS).
+MUltifrontal Massively Parallel sparse direct Solver (MUMPS).
 This installation of MUMPS is used by some other COIN-OR projects.
-
-This version of ThirdParty-Mumps retrieves and builds MUMPS 5.7.1.
-
-## Dependencies
-
-- MUMPS source requires a Fortran 90 compiler.
-
-- MUMPS requires LAPACK to be available. `configure` will look for a Lapack
-  installation, but if that does not succeed, the flags to link with Lapack
-  should be specified with the `--with-lapack-lflags` argument of `configure`.
-
-- MUMPS can make use of METIS. `configure` will look for a METIS library and
-  header, but if that does not succeed, the arguments `--with-metis-lflags`
-  and `--with-metis-cflags` can be specified for `configure`.
-
-...
diff --git a/ThirdParty-Mumps/Makefile b/ThirdParty-Mumps/Makefile
index 19d25ed483..6e8825c59b 100644
--- a/ThirdParty-Mumps/Makefile
+++ b/ThirdParty-Mumps/Makefile
@@ -1,28 +1,26 @@
 # $NetBSD$
 
-GITHUB_PROJECT=	ThirdParty-Mumps
-GITHUB_TAG=	refs/tags/releases/3.0.7
 DISTNAME=	3.0.7
 PKGNAME=	${GITHUB_PROJECT}-${DISTNAME}
-CATEGORIES=	# TODO: add primary category
+CATEGORIES=	math
 MASTER_SITES=	${MASTER_SITE_GITHUB:=coin-or-tools/}
+GITHUB_PROJECT=	ThirdParty-Mumps
+GITHUB_TAG=	refs/tags/releases/3.0.7
 DIST_SUBDIR=	${GITHUB_PROJECT}
 
-MAINTAINER=	INSERT_YOUR_MAIL_ADDRESS_HERE # or use pkgsrc-users%NetBSD.org@localhost
+MAINTAINER=	pkgsrc-users%NetBSD.org@localhost
 HOMEPAGE=	https://github.com/coin-or-tools/ThirdParty-Mumps/
-COMMENT=	TODO: Short description of the package
-#LICENSE=	# TODO: (see mk/license.mk)
+COMMENT=	COIN-OR autotools harness to build Mumps
+LICENSE=	epl-v1.0
 
 WRKSRC=		${WRKDIR}/ThirdParty-Mumps-releases-3.0.7
 GNU_CONFIGURE=	yes
 USE_LIBTOOL=	yes
 USE_TOOLS+=	pkg-config wget tar patch
-USE_LANGUAGES=	# none
+USE_LANGUAGES=	c fortran
 
 PKGCONFIG_OVERRIDE+=	coinmumps.pc.in
 
-USE_LANGUAGES=	c fortran
-
 MUMPS_MASTER_SITE=	http://coin-or-tools.github.io/ThirdParty-Mumps
 MUMPS_VERSION=		MUMPS_5.7.2
 MUMPS_DISTFILE=		${MUMPS_VERSION}.tar.gz
@@ -31,10 +29,10 @@ MUMPS_DISTFILE=		${MUMPS_VERSION}.tar.gz
 # FreeBSD port math/coin-or-mumps creates a soft link to auto-extracted file. How to do that in pkgsrc?
 # Change USE_TOOLS accordingly
 post-extract:
-	cd ${WRKSRC} && wget --no-check-certificate ${MUMPS_MASTER_SITE}/${MUMPS_DISTFILE} && tar xvzf ${MUMPS_DISTFILE} && $(LN) -s ${MUMPS_VERSION} MUMPS
+	cd ${WRKSRC} && wget --no-check-certificate ${MUMPS_MASTER_SITE}/${MUMPS_DISTFILE} && tar xvzf ${MUMPS_DISTFILE} && ${LN} -s ${MUMPS_VERSION} MUMPS
 
 post-patch: # patching from get.Mumps
-	@cd ${WRKSRC} && \
+	cd ${WRKSRC} && \
 		patch -p0 < mumps_mpi.patch && \
 		${MV} MUMPS/libseq/mpi.h MUMPS/libseq/mumps_mpi.h
 


Home | Main Index | Thread Index | Old Index