suitesparse: Better document Alma 8 hack

[Jason W. Bacon (via pkgsrc-wip) <commit-notify%pkgsrc.org@localhost>]

Module Name:	pkgsrc-wip
Committed By:	Jason W. Bacon <bacon%NetBSD.org@localhost>
Pushed By:	outpaddling
Date:		Wed Dec 18 15:26:38 2024 -0600
Changeset:	65233060ee0ca5601d65bb66503c132d1b577fa9

Modified Files:
	suitesparse/distinfo
	suitesparse/patches/patch-ParU_Source_paru__init__rowFronts.cpp

Log Message:
suitesparse: Better document Alma 8 hack

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=65233060ee0ca5601d65bb66503c132d1b577fa9

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 suitesparse/distinfo                                           |  2 +-
 .../patches/patch-ParU_Source_paru__init__rowFronts.cpp        | 10 ++++++----
 2 files changed, 7 insertions(+), 5 deletions(-)

diffs:
diff --git a/suitesparse/distinfo b/suitesparse/distinfo
index abb34acb9e..dadced54a2 100644
--- a/suitesparse/distinfo
+++ b/suitesparse/distinfo
@@ -4,5 +4,5 @@ BLAKE2s (SuiteSparse-7.8.2.tar.gz) = 098fcd79dfe355e65b366e112745fa77dab1889cc48
 SHA512 (SuiteSparse-7.8.2.tar.gz) = beb9ea85b47e46785a91913d0b52ef86a59f797f3a3a6df4fced31c4f990277ef627b6baae52256dea10e60e4eff5e82e8b5a3d6e20a63de47953674cf34f921
 Size (SuiteSparse-7.8.2.tar.gz) = 87337633 bytes
 SHA1 (patch-GraphBLAS_CMakeLists.txt) = 2f32b3534f08bcfd7fa5fc53dccbc6fd283a9976
-SHA1 (patch-ParU_Source_paru__init__rowFronts.cpp) = e6f7cf946b29fb7b7b1f6867f3d68c7d6f320e08
+SHA1 (patch-ParU_Source_paru__init__rowFronts.cpp) = 52fdeca699c598f745ce35210242f1480ab24426
 SHA1 (patch-SPQR_Source_spqr__factorize.cpp) = f8ad367e749435058f8df7c3961af8cf8b7dfb95
diff --git a/suitesparse/patches/patch-ParU_Source_paru__init__rowFronts.cpp b/suitesparse/patches/patch-ParU_Source_paru__init__rowFronts.cpp
index 49b3ded54d..5cfedee934 100644
--- a/suitesparse/patches/patch-ParU_Source_paru__init__rowFronts.cpp
+++ b/suitesparse/patches/patch-ParU_Source_paru__init__rowFronts.cpp
@@ -1,10 +1,10 @@
 $NetBSD$
 
-# Hack for Alma (RHEL) 8
+# Fix build on Alma (RHEL) 8
 
---- ParU/Source/paru_init_rowFronts.cpp.orig	2024-12-18 21:05:00.880749971 +0000
+--- ParU/Source/paru_init_rowFronts.cpp.orig	2024-08-24 17:13:32.000000000 +0000
 +++ ParU/Source/paru_init_rowFronts.cpp
-@@ -34,7 +34,15 @@ ParU_Info paru_init_rowFronts
+@@ -34,7 +34,17 @@ ParU_Info paru_init_rowFronts
      ParU_Numeric *Num_handle,
      // inputs, not modified:
      cholmod_sparse *A,
@@ -15,7 +15,9 @@ $NetBSD$
 +    // but some extant versions of gcc do this, while others (and clang)
 +    // error out if Sym is not included in the shared list.  Removing
 +    // default(none) is risky, as behavior may differ with different
-+    // compilers.
++    // compilers.  Since the code is confirmed to build on most platforms
++    // with const Sym, we know that nothing is trying to modify Sym after,
++    // so removing the const should not cause any problems.
 +    // const ParU_Symbolic Sym     // symbolic analysis
 +    ParU_Symbolic Sym     // symbolic analysis
  )