pkgsrc-WIP-changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

py-weewx: Add mqtt dependency and adjust comments



Module Name:	pkgsrc-wip
Committed By:	Greg Troxel <gdt%lexort.com@localhost>
Pushed By:	gdt
Date:		Tue Feb 4 07:44:34 2025 -0500
Changeset:	89c587aff64181a6d8ec70b8373cf3ba9273cf61

Modified Files:
	py-weewx/Makefile
Added Files:
	py-weewx/TODO

Log Message:
py-weewx: Add mqtt dependency and adjust comments

  - Depend on py-paho-mqtt, because it's normal to install the mqtt
    extension and it's lightweight.
  - Rototill the comments about upstream handling of config files.
  - Add TODO

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=89c587aff64181a6d8ec70b8373cf3ba9273cf61

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 py-weewx/Makefile | 18 ++++++++++++------
 py-weewx/TODO     | 12 ++++++++++++
 2 files changed, 24 insertions(+), 6 deletions(-)

diffs:
diff --git a/py-weewx/Makefile b/py-weewx/Makefile
index 3a96e75294..fd3f1f8e30 100644
--- a/py-weewx/Makefile
+++ b/py-weewx/Makefile
@@ -2,6 +2,7 @@
 
 DISTNAME=	weewx-5.1.0
 PKGNAME=	${PYPKGPREFIX}-${DISTNAME:tl}
+PKGREVISION=	1
 CATEGORIES=	misc
 MASTER_SITES=	https://weewx.com/downloads/released_versions/
 EXTRACT_SUFX=	.tgz
@@ -31,20 +32,25 @@ DEPENDS+=	${PYPKGPREFIX}-pymysql>=1.0:../../databases/py-pymysql
 DEPENDS+=	${PYPKGPREFIX}-serial>=3.4:../../comms/py-serial
 DEPENDS+=	${PYPKGPREFIX}-usb>=1.0.2:../../devel/py-usb
 
-REPLACE_PYTHON+=		src/weewx_data/util/i18n/i18n-report
+# Dependencies of common extensions, as long as they are not heavy.
+#   mqtt
+DEPENDS+=	${PYPKGPREFIX}-paho-mqtt>=2:../../net/py-paho-mqtt
+
+REPLACE_PYTHON+=	src/weewx_data/util/i18n/i18n-report
 
 # Ignore perl rather than depend on it.  For now, don't even consider
 # a split package.
 CHECK_INTERPRETER_SKIP+=	${PYSITELIB}/weewx_data/util/logwatch/scripts/services/weewx
 
-DOCDIR=		${PREFIX}/share/doc/weewx-${PYVERSSUFFIX}
+DOCDIR=			${PREFIX}/share/doc/weewx-${PYVERSSUFFIX}
 
 INSTALLATION_DIRS=	${DOCDIR}
 
-# \todo Grasp and perhaps deal with config file generation/update.
-
-# \todo Consider how to manage edits to skins, which are sort of code
-# and sort of config files.
+# weewx 4.x had code and data in the same dir, and setup.py install
+# would merge config file changes.  weewx 5.x does not appear to do
+# this, and the user is left to manually adjust or not, as is the
+# usual custom.  This comment is a caution that the config file
+# behavior is not entirely understood.  This also applies to skins.
 
 post-install:
 	${RM} -f ${DESTDIR}/${PREFIX}/${PYSITELIB}/LICENSE.txt
diff --git a/py-weewx/TODO b/py-weewx/TODO
new file mode 100644
index 0000000000..3445189bba
--- /dev/null
+++ b/py-weewx/TODO
@@ -0,0 +1,12 @@
+This package is useful in wip, and awkward to hoist to pkgsrc.
+
+  - Consider installing an rc.d script.
+
+  - Issues best addressed upstream, not really about the package.
+    - Put "schema" under a weewx namespace; it's awkward at site-packages top level.
+    - Install examples in examples.
+    - Don't have weectl station put examples in user config dir
+
+  - Consider an option for py-requests (needed for some drivers).  But
+    really people can just install it.
+    


Home | Main Index | Thread Index | Old Index