Tobias Nygren wrote:
I'd like to commit the following to wip/mk/cvs-package.mk.
Any thoughts before I go ahead?
Index: mk/cvs-package.mk
===================================================================
RCS file: /cvsroot/pkgsrc-wip/wip/mk/cvs-package.mk,v
retrieving revision 1.10
diff -u -r1.10 cvs-package.mk
--- mk/cvs-package.mk 30 Jan 2006 02:34:18 -0000 1.10
+++ mk/cvs-package.mk 15 Feb 2006 19:21:43 -0000
@@ -49,7 +49,12 @@
_CVS_ENV+= CVS_PASSFILE=${_CVS_PASSFILE:Q}
_CVS_ENV+= CVS_RSH=${_CVS_RSH:Q}
_CVS_FLAGS= -Q
-_CVS_CHECKOUT_FLAGS= -P -r ${CVS_TAG:Q}
+_CVS_CHECKOUT_FLAGS= -P
+.if !defined(CVS_DATE)
+_CVS_CHECKOUT_FLAGS+= -r ${CVS_TAG:Q}
+.else
+_CVS_CHECKOUT_FLAGS+= -D ${CVS_DATE:Q}
+.endif
That's a great idea. But the CVS_DATE should be configurable per repository, not globally. (The current definition of CVS_TAG is also a mess, but I didn't notice that earlier.)
And, you didn't document your extension in the files' header comment. :) Roland ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 _______________________________________________ pkgsrc-wip-discuss mailing list pkgsrc-wip-discuss%lists.sourceforge.net@localhost https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-discuss