Re: tlsdate port to NetBSD?

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Sat, Apr 13, 2013 at 01:04:27AM +0000, Jacob Appelbaum wrote:
> As of 4b25b76 in
> https://github.com/ioerror/tlsdate/commit/4b25b76e03b5830c8f340b4d54409d3a205329fa
> I've added NetBSD support.

Great!
I've tried on NetBSD-6.99.19/amd64, and it builds and passes its self-tests.

# make
make  all-am
  CC       src/compat/src_compat_libtlsdate_compat_la-clock-linux.lo
  CCLD     src/compat/libtlsdate_compat.la
  CC       src/src_tlsdate-tlsdate.o
  CCLD     src/tlsdate
  CC       src/src_tlsdate_helper-tlsdate-helper.o
src/tlsdate-helper.c: In function ‘validate_proxy_port’:
src/tlsdate-helper.c:125:5: warning: array subscript has type ‘char’
  CC       src/src_tlsdate_helper-proxy-bio.o
  CC       src/src_tlsdate_helper-util.o
  CCLD     src/tlsdate-helper
  CC       src/conf.o
src/conf.c: In function ‘eat_whitespace’:
src/conf.c:30:3: warning: array subscript has type ‘char’
  CC       src/conf-unittest.o
  CC       src/common/android.o
  CCLD     src/conf_unittest
  CC       src/proxy-bio.o
  CC       src/proxy-bio-unittest.o
  CC       src/test-bio.o
  CC       src/util.o
  CCLD     src/proxy-bio_unittest
# make check
make  check-am
make    src/conf_unittest       src/proxy-bio_unittest   
src/test/proxy-override src/test/return-argc  src/test/rotate 
src/test/sleep-wrap
`src/conf_unittest' is up to date.
`src/proxy-bio_unittest' is up to date.
`src/test/proxy-override' is up to date.
`src/test/return-argc' is up to date.
`src/test/rotate' is up to date.
`src/test/sleep-wrap' is up to date.
make  check-TESTS
PASS: src/conf_unittest
PASS: src/proxy-bio_unittest
make  all-am
============================================================================
Testsuite summary for tlsdate 0.0.6
============================================================================
# TOTAL: 2
# PASS:  2
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================

The two warnings are about isdigit(char) and isspace(char) -- NetBSD
quite forcefully expects unsigned char there.

> >> If anyone has already managed to port tlsdate to NetBSD, I'd love to
> >> know before I set out to port it. :)
> > 
> > I've just tried the git version on NetBSD-current with some packages
> > installed.
> > 
> > git clone https://github.com/ioerror/tlsdate
> > autoreconf -fiv
> > ./configure
> > (output attached)
> > make
> 
> So I've got it building now from a tar.gz produced from another
> machine's ``make dist`` tar.gz.
> 
> I'm still having some automake/autoconf/autotools issues - what is it
> that the Germans say? Die autotools? My thoughts exactly...
> 
> Basically, I get this if I try to run ./autogen.sh:
> 
> autoreconf: Entering directory `.'
> autoreconf: configure.ac: not using Gettext
> autoreconf: running: aclocal --force -I m4
> configure.ac:17: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call
> detected in body
> ../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded from...
> ../../lib/autoconf/general.m4:2661: _AC_LINK_IFELSE is expanded from...
> ../../lib/autoconf/general.m4:2678: AC_LINK_IFELSE is expanded from...
> m4/libtool.m4:1022: _LT_SYS_MODULE_PATH_AIX is expanded from...
> m4/libtool.m4:4170: _LT_LINKER_SHLIBS is expanded from...
> m4/libtool.m4:5253: _LT_LANG_C_CONFIG is expanded from...
> m4/libtool.m4:138: _LT_SETUP is expanded from...
> m4/libtool.m4:67: LT_INIT is expanded from...
> configure.ac:17: the top level
> configure.ac:17: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call
> detected in body
> ../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded from...
> ../../lib/autoconf/general.m4:2661: _AC_LINK_IFELSE is expanded from...
> ../../lib/autoconf/general.m4:2678: AC_LINK_IFELSE is expanded from...
> m4/libtool.m4:4170: _LT_LINKER_SHLIBS is expanded from...
> m4/libtool.m4:5253: _LT_LANG_C_CONFIG is expanded from...
> m4/libtool.m4:138: _LT_SETUP is expanded from...
> m4/libtool.m4:67: LT_INIT is expanded from...
> configure.ac:17: the top level
> aclocal: error: /usr/pkg/bin/autom4te failed with exit status: 1
> autoreconf: aclocal failed with exit status: 1

I see this too, but plain 'autoreconf -fiv' (basically, the last line
of your script) works fine. Probably it's the 'set -e' you add at the
top.

> As it now works from a release tar.gz, I feel a less pressure to fix
> those issues today. Help on this front would be welcome, otherwise, I'll
> try to fix it later this weekend or next week.

If you still want access to a NetBSD-current, just send me your ssh
public id key.

Cheers,
 Thomas

------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
pkgsrc-wip-discuss mailing list
pkgsrc-wip-discuss%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-discuss