Re: pkg_select upgrade

[Jachym Holecek <freza%liberouter.org@localhost>]

> Build failed on NetBSD/amd64.
>
> [...]
> 
> I think we have two options.
> Casting a variable to int in pkgselect source code or in ctype.h
> 
> Option #1 would be like this:
> In ftpio.c file,
> -                               if (ftprc && isdigit(buf[match.rm_so+1]))
> +                               if (ftprc && isdigit((int)buf[match.rm_so+1]))
> 
> And here is option #2:
> In /usr/src/include/ctype.h file,
> -#define isdigit(c)      ((int)((_ctype_ + 1)[(c)] & _N))
> +#define isdigit(c)      ((int)((_ctype_ + 1)[(int)(c)] & _N))

isdigit(3) says the prototype is "int isdigit(int c);", so #1 would seem
correct.

        Regards,
                -- Jachym Holecek


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review