Re: Review request for some new packages in WIP

[Klaus Heinz <k.heinz.aug.fuenf%onlinehome.de@localhost>]

Roman Kulik wrote:

> p5-Text-German

The content of DESCR was copied verbatim from the README file, which is not
wrong as a matter of principle, but a) it contains all the spelling errors
from the README file and b) does not tell me in the least what the
module is supposed to do. I would like to see a description of the
module's purpose.

The indentation of the Makefile could be improved.

The current version of the module (according to CPAN) is Text-German-0.06
from 03 Apr 2005. Is there any reason not to use this one?

I know other packages use it that way as well, but I would prefer
${MASTER_SITE_PERL_CPAN:=Text/} instead of
${MASTER_SITE_PERL_CPAN:=../../authors/id/U/UL/ULPFR/}; it is shorter
and independent of the CPAN maintainer.

> p5-Date-Range

This package does not build for me. It requires time/p5-Date-Simple while
this package is only available as wip/p5-Date-Simple.

It looks like p5-Date-Simple is not only a requirement for building
(BUILD_DEPENDS) but is also needed during runtime (DEPENDS), it is used in
Date/Range.pm.

Why is p5-Test-Simple needed at all? I cannot see any reference to this
module in the code and it is not listed in Makefile.pl.

Since the package does not use XS and no compiler is needed you should
set
  USE_LANGUAGES=        # empty


> Can someone tell me if it is better to send a request for package review 
> for each individual package rather then listing them all here in 1 email?

One message is better than 32 requests for review, IMO.

ciao
     Klaus


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review