Re: Seeking reviews of wip/oak

[Thomas Klausner <thomasklausner%users.sourceforge.net@localhost>]

On Wed, Mar 08, 2006 at 07:21:40PM -0600, Jason White wrote:
> Oak is a program that can be used to monitor syslogs from a collection
> of servers and notify operators when problem conditions arise. In
> addition to providing immediate notification of critical problems, oak
> will also batch less critical problems into summary messages that can be
> sent less often and via any medium.

CONF_FILES should point to PKG_SYSCONFDIR as target.
Of course, the program should be fixed to look for its config
file(s) there too.

I'd prefer
        ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/oak
to the INSTALLATION_DIRS line.

patch-ab, ac: use sizeof(buffer)-1 instead of the hardwired sizes
in the strncpy, and NUL-terminate the buffers manually. Or use
strlcpy.

patch-ad: you could put the file in files/ and install it in
the post-install step too -- that'd make editing it easier
(I have some ideas on how to improve it).

Cheers,
 Thomas


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review