Re: PR #33227, textproc/dict-server package

[Aleksey Cheusov <cheusov%tut.by@localhost>]

> On Jul 14, 2006, at 1:23 AM, Aleksey Cheusov wrote:

 >>
 >> fixed and updated version of textproc/dict-server
 >> is in wip/dict-server now.
 >> Any comments, sudgestions?

> - In MESSAGE, I think 1) is pretty general, and doesn't belong to the
> MESSAGE file of a single package.

> - MESSAGE contains a hardcoded path to m4.  If this is used by the
> package, Makefile should contain USE_TOOLS+=m4 and the hardcoded path
> be replaced with whatever the tools framework selects.
I've fixed this in the following way. Is this ok?
A added :run because m4 is needed at run time
at the moment of starting a daemon.
Is there any _easy_ way
to replace m4 with ${TOOLS_PATH.m4} in files/dictd.sh?

Index: MESSAGE
===================================================================
RCS file: /cvsroot/pkgsrc-wip/wip/dict-server/MESSAGE,v
retrieving revision 1.3
diff -u -r1.3 MESSAGE
--- MESSAGE     12 Jul 2006 15:26:32 -0000      1.3
+++ MESSAGE     18 Jul 2006 18:59:12 -0000
@@ -1,20 +1,11 @@
 ===========================================================================
 $NetBSD: MESSAGE,v 1.6 2005/11/01 12:22:24 abs Exp $
 
-1) To enable "dictd" to start on boot on NetBSD-1.5 or newer,
-   please copy "${PREFIX}/${RCD_SCRIPTS_EXAMPLEDIR}/dictd" to
-   "/etc/rc.d/" and add "dictd=YES" to /etc/rc.conf. To do the
-   same on older systems, add the following to /etc/rc.local:
-
-   if [ -x ${PREFIX}/${RCD_SCRIPTS_EXAMPLEDIR}/dictd ]; then
-      ${PREFIX}/${RCD_SCRIPTS_EXAMPLEDIR}/dictd
-   fi
-
-2) By default dictd uses '/usr/bin/m4 -P' for
+1) By default dictd uses '${TOOLS_PATH.m4} -P' for
    preprocessing configuration file. If you dislike this default
    add dictd_flags='<your options>' to /etc/rc.conf.
 
-3) ${VARBASE}/log/dictd is a preferred directory for logging unless
+2) ${VARBASE}/log/dictd is a preferred directory for logging unless
    syslog is used.
 
 ===========================================================================
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc-wip/wip/dict-server/Makefile,v
retrieving revision 1.9
diff -u -r1.9 Makefile
--- Makefile    16 Jul 2006 19:55:35 -0000      1.9
+++ Makefile    18 Jul 2006 18:59:12 -0000
@@ -10,12 +10,13 @@
 HOMEPAGE=      http://www.dict.org/
 COMMENT=       Dictionary Service Protocol server
 
-USE_TOOLS+=            gmake yacc
+USE_TOOLS+=            gmake yacc m4:run
 GNU_CONFIGURE=         yes
 CONFIGURE_ARGS+=       --with-cflags=${CFLAGS:M*:Q}
 CONFIGURE_ARGS+=       --disable-plugin
 
 MESSAGE_SUBST+=                VARBASE="${VARBASE}"
+MESSAGE_SUBST+=                TOOLS_PATH.m4="${TOOLS_PATH.m4}"
 INSTALLATION_DIRS+=    share/dictd
 
 PKG_GROUPS=            dictd

-- 
Best regards, Aleksey Cheusov.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review