Re: Please review wip/mxallowd

["OBATA Akio" <obache%users.sourceforge.net@localhost>]

Hi! Thanks for your packaging!

On Mon, 11 Aug 2008 00:57:08 +0900, Michael Stapelberg 
<michael+pkgsrc%stapelberg.de@localhost> wrote:

> as wip/mxallowd is my first package, please review it :-).

Items in Makefile should be sorted by usual order and tabs should be inserted 
after "=".
pksrc/doc/Makefile-example and "pkglint -Wvarorder" may help you.

> CONFIGURE_ARGS+=--prefix=/usr/pkg

You must not hard coded /usr/pkg.
Use ${PREFIX} instead.

> CONFIGURE_ARGS+=--sysconfdir=${PREFIX}/etc

You must pass ${PKG_SYSCONFDIR} instead of ${PREFIX}/etc.
(Other part using ${PKG_SYSCONFDIR} though...)

> DISTFILES=mxallowd.1.6.tar.bz2

You can use EXTRACT_SUFX=.tar.bz2 instead of DISTFILES difinition

> patch-aa

No need to delete Linux specific parts.
Linux users also usig pkgsrc.

> patch-ad

You also should patch to creation of man dir.
(This point should be sent to upstream author).

And this package is using pthread.
You should include ../../mk/pthread.buildlink3.mk and
replace "-lpthread" in ${WRKSRC}/configure with ${PTHREAD_LDFLAGS} and 
${PTHREAD_LIBS}
and "-D_REENTRANT" in ${WRKSRC}/Makefile with ${PTHREAD_CFLAGS}.

-- 
"Of course I love NetBSD":-)
OBATA Akio / obache%users.sourceforge.net@localhost

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review