Re: new package: gallery2

["OBATA Akio" <obache%users.sourceforge.net@localhost>]

Hi,

> DEPENDS+=             
> {mysql-,pgsql-}server-[0-9]*:../../databases/mysql5-server

Probably no need to depend on database servers.

> SUBST_SED.paths+=     -e 's,@G2DIR@,${G2DIR},g'
> SUBST_SED.paths+=     -e 's,@G2DATA@,${G2DATA},g'

You can use
SUBST_VARS.paths=       G2DIR G2DATA

> do-install:
>       ${INSTALL_DATA} ${WRKDIR}/gallery2.conf ${EGDIR}/gallery2.conf
>       ${CP} -R ${WRKSRC}/* ${G2DIR}
>       ${CHMOD} 666 ${G2DIR}/config.php
>       ${INSTALL_DATA} ${FILESDIR}/.htaccess ${G2DIR}/.htaccess

You can add DESTDIR support.

And for config.php, how about using CONF_FILES?

-- 
"Of course I love NetBSD":-)
OBATA Akio / obache%users.sourceforge.net@localhost

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review