pkgsrc-WIP-review archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Please review wip/openct wip/opensc and wip/opensc-signer



Hi,

On Wed, 18 Feb 2009 20:48:06 +0900, Hasso Tepper <hasso%estpak.ee@localhost> 
wrote:

> I'm really pleased now with these myself now (after splitting opensc) and
> would like to move these into the pkgsrc base if no one objects.

Just a quick review.

In opensc/options.mk,
* ${PREFIX} should be replaced with ${BUILDLINK_PREFIX.pcsc-lite}
* I don't know the ext of "libpcsclite.so" is good for all platform
  (dylib for Darwin?  sl for HP-UX?)

And just a fun...
opensc/openct both have pcsc-lite option, and opensc optionally
depend on openct. pcsc-lite is used on opensc/openct independently?

-- 
"Of course I love NetBSD":-)
OBATA Akio / obache%users.sourceforge.net@localhost

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review


Home | Main Index | Thread Index | Old Index