Re: CVS commit: wip/dwm

[Leonardo Taccari <leonardo1990%gmail.com@localhost>]

Hello Petar,

On Thu, May 14, 2009 at 10:26:17PM +0200, Petar Bogdanovic wrote:
> Since the package claims PKG_DESTDIR_SUPPORT, you should put
> ${DESTDIR} somewhere when doing these substitutions.
> 
> Instead of using SUBST you could also override do-install:
> 
>    do-install:
>       ${INSTALL_PROGRAM} ${WRKSRC}/dwm ${DESTDIR}${PREFIX}/bin
>       ${INSTALL_MAN} ${WRKSRC}/dwm.1 ${DESTDIR}${PREFIX}/${PKGMANDIR}/man1
> 
> (excerpt from wm/dwm)
I don't like the wm/dwm's way: the suckless project offers Makefile so,
why do not simply use their targets instead of do-target?

About PKG_DESTDIR_SUPPORT please give a look to the dwm's Makefile, it
should be ok.


Ciao, Leonardo
-- 
 Leonardo Taccari | Peace, love and NetBSD. | http://freeshells.ch/~leot/

------------------------------------------------------------------------------
The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
production scanning environment may not be a perfect world - but thanks to
Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
Series Scanner you'll get full speed at 300 dpi even with all image 
processing features enabled. http://p.sf.net/sfu/kodak-com
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review