Re: wip/sphinsearch

[Filip Hajny <filip%joyent.com@localhost>]

On 2.10.2009, at 1:52, OBATA Akio wrote:

>> The latter two ones - I'm not sure. Is the proper way to persuade/
>> patch the package's install target to stop copying .a and .la lib  
>> files?
>
> No, just remove them (and lib/libsphinxclient-0.0.1.so?) from PLIST,
> because they will be generated automatically from .la files
> (shlib file names are platform depend).
>
> Some more suggestions:
> * No need to contains ${DESTDIR}${PREFIX} in INSTALLATION_DIRS.
>   If it is relative paths, assumed as in ${PREFIX}.

Thanks, committing these fixes in a bit.

> * If this package require either mysql or postgresql, you should use  
> PKG_OPTIONS_REQUIRED_GROUPS.
>   (ref. www/ja-trac/options.mk)

This is not the case - mysql/pgsql support is not exclusive with  
Sphinx Search, it's just a matter of whether you want support for  
either or both built in at all.

--
Filip Hajny
Joyent Inc.


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review