pkgsrc-WIP-review archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: Review-Request: wip/libpar2
Hi,
On Fri, 29 Oct 2010 05:30:12 +0900, Volkmar Seifert
<vs%nifelheim.info@localhost> wrote:
> please review wip/libpar2, which I just have committed.
* No need to add --prefix=... to CONFIGURE_ARGS, it will be automatically added
with GNU_CONFIGURE=yes.
* Adding lib/libpar2 to BUILDLINK_LIBDIRS is probably not good
because it only contains a header file.
and you can clean `pkglint -Wall' warnings.
--
OBATA Akio / obache%users.sourceforge.net@localhost
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review
Home |
Main Index |
Thread Index |
Old Index