Re: Please review soqt

[Aleksey Cheusov <vle%gmx.net@localhost>]

> Hi again!

> I also just commited soqt.  Can you also review it?
It is recomended to use += for USE_TOOLS.

   0 soqt>pkglint -Wall 
   WARN: Makefile:20: Permission [s] requested for USE_TOOLS, but only [a] is 
allowed.
   0 errors and 1 warnings found.

   0 soqt>

If fortran is not needed for building the project, it is better to
remove it from USE_LANGUAGES. What type of warnings are you talking
about in comment lines?

Personally, I'd rewrite PKGNAME and DISTNAME as the following

   DISTNAME=       SoQt-1.4.1
   PKGNAME=        ${DISTNAME:S/SoQt/soqt/}

but this is only my opinion.

-- 
Best regards, Aleksey Cheusov.

------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review