Re: Please review wip/muttprint

[Thomas Klausner <thomasklausner%users.sourceforge.net@localhost>]

On Sun, Mar 11, 2012 at 09:01:56PM +0530, Mayuresh wrote:
> muttprint is a pretty printer for emails that integrates with mutt as well
> as several other email clients.
> 
> Please review. Following are the changes done to adopt to pkgsrc:
> 
> - I have patched the Makefile of the package with paths adjusted using
>   ${DESTDIR}/${PREFIX}. Is this the right way?

It is ok, as long as the paths are not included in the binaries
themselves.

> - I have not added latex as a dependency since there are various
>   distributions. I have hence included a message regarding the same.

Well, no. It's a mixture. Pkgsrc is migrating to texlive, but as long
as it's not fully there, the remaining parts come from the teTeX
distribution.

Please add the missing dependencies that muttprint needs.

> - The program muttprint-langinfo is probably not required. Not sure.
>   Package Makfile and PLIST may be patched accordingly.

I can't say -- what does it do?

> - There were makefiles in doc directories that gave an error regarding
>   *.css not found. There were no css files in the sources. So I just
>   removed those actions.

Upstream probably forgot including the files in the tarball. Please
ask them about it.

> - There is a bug that causes "cannot remove path when cwd is
>   /tmp/muttprint" error. A patch to cd the cwd to ~ is discussed on some
>   mailing lists. Have adopted the same.

The patch looks weird :)
Is there an official upstream commit for this?

Please add comments to the patches (like the paragraphs above; or in
the last case, with a URL to the discussion + patch).

Otherwise this looks fine, thank you!
 Thomas

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review