Re: Please review wip/polarssl

[Moritz Wilhelmy <ml+pkgsrc%wzff.de@localhost>]

On Sun, Aug 12, 2012 at 19:22:12 +0200, Thomas Klausner wrote:
> PKGNAME=                ${DISTNAME:-gpl=}
> it's ok, but more common is
> PKGNAME=                ${DISTNAME:S/-gpl//}

Alright.

> WRKSRC=                 ${WRKDIR}/${DISTNAME:-gpl=}
> use
> WRKSRC=                       ${WRKDIR}/${PKGNAME_NOREV}

Isn't NOREV cutting the revision number as well?
I want the same thing as ${PKGNAME}, but pkglint didn't like when I used
that variable.
I'm not sure to what degree I should listen to it, given that it's just
a tool. (I'm thinking about ignoring illegitimate compiler warnings and
things like that)

> pkglint complains that the patches have no comments.

Well, they are all rather obvious patches to Makefiles, but I'll change
that.

Best regards,

Moritz

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review