Re: please review wip/cacti-spine

[Nils Ratusznik <nils.sf.net%anotherhomepage.org@localhost>]

----- Mail original -----
> > DISTFILES=              ${DISTNAME}${EXTRACT_SUFX}
> 
> You can use ${DEFAULT_DISTFILE} instead.

It breaks the build. This looks linked to the manpage and its patch.

> 
> > DISTFILES+=             spine.1.gz
> > SITES.spine.1.gz=       \
> >        http://manpages.ubuntu.com/manpages.gz/precise/man1/
> 
> Is it useful for other tha Ubuntu?
> We are not neither Debian nor Ubuntu,
> so man pages for all commands are not required.

I added this manpage after a pkglint run. Since there is no man page in spine's 
archive, I took the manpage where it is.
Should I remove the man page and ignore future messages from pkglint about it ?

> > USE_TOOLS+=     autoconf autoheader automake aclocal
> 
> I cannot find where such auto tools are used.
> 
> > BUILD_DEPENDS+= automake-[0-9]*:../../devel/automake
> 
> It will not be required, already in USE_TOOLS.

I removed these 2 lines from the Makefile, and the package still builds :-)

Thank you very much for your review !

-- 
Nils

------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review