Re: New package devel/py-tortoisehg

["Kamil Rytarowski" <n54%gmx.com@localhost>]

 ----- Original Message -----
From: Thomas Klausner
Sent: 03/28/14 08:58 AM
To: Kamil Rytarowski
Subject: Re: New package devel/py-tortoisehg
 On Fri, Mar 28, 2014 at 03:45:45AM +0100, Kamil Rytarowski wrote:
> I've packaged TortoiseHG, it's a GUI for the Mercurial VCS.
> 
> The package is available on github [1], on my public account.
> 
> [1] 
> https://github.com/krytarowski/pkgsrc-2013Q4/tree/tortoisehg/devel/py-tortoisehg

Please take a look at the already existing wip/tortoisehg (perhaps the
name should be changed) and merge any improvements you have.

Thanks,
 Thomas

----

Hello!
Funny, when I started to work on tortoisehg, it was still absent. As this is 
new package still in-progress and I'm new here, I'm attaching a patch with my 
possibly changes:
1) Add python to CATEGORIES
2) Rename to py-tortoisehg (as purely Python)
3) Mercurial's Python version compatibility (the trick from py-hgview)
4) Use ${RUN} for shell commands (I supposed we need it always)

The last thing, I don't understand the purpose of USE_LANGUAGES= c for a pure 
python-software?

I'm waiting for your feedback and green light to apply the changes.

With regards,

diff --git a/wip/tortoisehg/Makefile b/wip/tortoisehg/Makefile
index c461926..322b40e 100644
--- a/wip/tortoisehg/Makefile
+++ b/wip/tortoisehg/Makefile
@@ -1,7 +1,8 @@
 # $NetBSD$
 
 DISTNAME=              tortoisehg-2.11.1
-CATEGORIES=            devel
+PKGNAME=               ${PYPKGPREFIX}-${DISTNAME}
+CATEGORIES=            devel python
 MASTER_SITES=          http://bitbucket.org/tortoisehg/targz/downloads/
 
 MAINTAINER=            nros%users.sourceforge.net@localhost
@@ -20,9 +21,10 @@ DEPENDS+=    
${PYPKGPREFIX}-pygments>=1.6:../../textproc/py-pygments
 DEPENDS+=      mercurial>=2.8.1:../../devel/mercurial
 
 PYTHON_VERSIONS_INCOMPATIBLE=  33 # py-iniparse
+PYTHON_VERSIONS_INCOMPATIBLE+= 26 # imports modules from mercurial, so needs 
to be the same version
 
 pre-configure:
-               sed     -e 's:@PREFIX@:${PREFIX}:g' \
+               ${RUN} sed      -e 's:@PREFIX@:${PREFIX}:g' \
                        ${FILESDIR}/config.py > \
                        ${WRKSRC}/tortoisehg/util/config.py
 
@@ -34,8 +36,10 @@ SUBST_FILES.df=              contrib/thg.desktop
 SUBST_SED.df=          -e 's:thg_logo:${PREFIX}${thg_icon}:1'
 
 pre-build:
-       cd ${WRKSRC}/doc && ${MAKE_PROGRAM} html
-       rm ${WRKSRC}/doc/build/html/.buildinfo
+       ${RUN} cd ${WRKSRC}/doc && ${MAKE_PROGRAM} html
+       ${RUN} rm ${WRKSRC}/doc/build/html/.buildinfo
+
+.include "../../lang/python/pyversion.mk"
 
 .include "../../lang/python/application.mk"
 .include "../../lang/python/extension.mk"

------------------------------------------------------------------------------

_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review