Subject: Changes for review
To: None <port-arc@netbsd.org>
From: M. Warner Losh <imp@bsdimp.com>
List: port-arc
Date: 12/03/2002 18:29:27
Since I'm not sure who the right people to send this directly to are,
please excuse the intrusion while I post this here.
I'm building a kernel for my arc box. Right now I have it linking a
custom kernel, but don't have that kernel working yet.
I've encountered three problems. One I punted on, the other two are
easy to 'fix' but I wanted to find out if the fixes were good.
First problem:
cc ... -c ../../../../arch/arc/arc/c_isa.c
../../../../arch/arc/arc/c_isa.c: In function `c_isa_cons_init':
../../../../arch/arc/arc/c_isa.c:192: `KBCMDP' undeclared (first use in this function)
That's easy to fix by including machine/kbdreg.h when we have NPCKBC > 0.
Second problem is link error because of a problem with jazzio. I've
removed the # XXX's, but don't know why they were there.
Comments?
Warner
Index: arc/c_isa.c
===================================================================
RCS file: /home/imp/NetBSD/CVS/syssrc/sys/arch/arc/arc/c_isa.c,v
retrieving revision 1.1
diff -u -r1.1 c_isa.c
--- arc/c_isa.c 2001/06/13 15:27:17 1.1
+++ arc/c_isa.c 2002/12/04 00:30:58
@@ -1,4 +1,4 @@
-/* $NetBSD: c_isa.c,v 1.1 2001/06/13 15:27:17 soda Exp $ */
+/* $NetBSD: isabus.c,v 1.14 2000/12/24 09:25:27 ur Exp $ */
/* $OpenBSD: isabus.c,v 1.15 1998/03/16 09:38:46 pefo Exp $ */
/*-
@@ -121,6 +121,7 @@
#include "pckbc.h"
#if NPCKBC > 0
#include <dev/ic/pckbcvar.h>
+#include <machine/kbdreg.h>
#endif
#include "com.h"
Index: conf/files.arc
===================================================================
RCS file: /home/imp/NetBSD/CVS/syssrc/sys/arch/arc/conf/files.arc,v
retrieving revision 1.41
diff -u -r1.41 files.arc
--- conf/files.arc 2002/11/30 19:23:46 1.41
+++ conf/files.arc 2002/12/04 00:39:25
@@ -114,9 +114,9 @@
device jazzio {}
attach jazzio at mainbus # optional
file arch/arc/jazz/jazzio.c jazzio
-file arch/arc/jazz/dma.c # XXX jazzio
-file arch/arc/jazz/jazzdmatlb.c # XXX jazzio
-file arch/arc/jazz/bus_dma_jazz.c # XXX jazzio
+file arch/arc/jazz/dma.c jazzio
+file arch/arc/jazz/jazzdmatlb.c jazzio
+file arch/arc/jazz/bus_dma_jazz.c jazzio
#
# ISA Bus bridge