Subject: Re: Changes for review
To: None <soda@sra.co.jp>
From: M. Warner Losh <imp@bsdimp.com>
List: port-arc
Date: 12/03/2002 23:23:48
In message: <200212040217.LAA18517@srapc342.sra.co.jp>
Noriyuki Soda <soda@sra.co.jp> writes:
: >>>>> On Tue, 03 Dec 2002 18:29:27 -0700 (MST),
: "M. Warner Losh" <imp@bsdimp.com> said:
:
: > First problem:
: > cc ... -c ../../../../arch/arc/arc/c_isa.c
: > ../../../../arch/arc/arc/c_isa.c: In function `c_isa_cons_init':
: > ../../../../arch/arc/arc/c_isa.c:192: `KBCMDP' undeclared (first use in this function)
:
: > That's easy to fix by including machine/kbdreg.h when we have NPCKBC > 0.
:
: Thanks.
: Will you commit the fix by yourself?
Yes. I wanted to make sure that was the right fix.
: > Second problem is link error because of a problem with jazzio. I've
: > removed the # XXX's, but don't know why they were there.
:
: I forgot the reason why I put the XXX there.
:
: Perhaps arc port was not clean enough at that time.
: And the XXX could be removed since the day when struct platform was
: introduced at June 2002.
Although it would take a little while, I could build all the kernels
in CVS with this change to see if it breaks anything.
I could also commit the RPC44 kernel that I have to test with.
Warner