Jason R Thorpe <thorpej@wasabisystems.com> writes:

> On Thu, Sep 19, 2002 at 02:09:14AM +0900, Hiroyuki Bessho wrote:
>
>  >     Is it ok to modify sys/arch/arm/include/cpu.h as in following
>  > patch?
>  > 
>  >     I want to move prototype of atomic_{set,clear}_bit() so that I can
>  > use them in inline functions that are defined in a header file which
>  > is included from <machine/intr.h>.
>
> Does this work properly when <machine/intr.h> is included on its own?
>

    For evbarm, it's ok because <machine/cpu.h> is included before
BOARDTYPE_intr.h in <machine/intr.h>.

> Hmmmm... those atomic funcs probably ought to be put in <machine/atomic.h>
> as inlines, or something.
>

    It sounds nice to make them inline, but why not <arm/atomic.h>?  

--
bsh.