Subject: Re: port-shark/22355 [was: Help needed to fix NetBSD/shark]
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
From: Julio M. Merino Vidal <jmmv84@gmail.com>
List: port-arm
Date: 08/06/2007 10:28:36
On 05/08/2007, at 13:25, Izumi Tsutsui wrote:
> chris@dokein.co.uk wrote:
>
>> What worries me, and a version with more debugging that jmmv ran
>> showed
>> errors that clockintr doesn't reset the the spl level after every
>> call,
>> which is why the mask is wrong.
>>
>> So these patches are just hiding an underlying bug somewhere else by
>> reseting the spl_mask after interrupt routines are called, however
>> the
>> mask should have been reset back by an splx call.
>
> The attached one also seems to fix the problem.
> (use spl_masks[current_spl_level] rather than spl_mask in
> irq_setmask())
Indeed. I've been running the machine under load (building some
packages) with your patch applied and it has been flawless.
The only thing that worries me (based on Chris' comments) is that
this might be hiding some other problem instead of fixing the real
root cause. But I don't know enough to see if that's the case or not...
--
Julio M. Merino Vidal <jmmv84@gmail.com>