Re: BEAGLEBONE 8.0_BETA kernel fails

[Nick Hudson <skrll%netbsd.org@localhost>]

On 08/21/17 05:15, John D. Baker wrote:
> On Sun, 20 Aug 2017, Nick Hudson wrote:
>
> > https://nxr.netbsd.org/xref/src/sys/arch/arm/omap/am335x_prcm.c#64
> >
> > This is the most likely candidate - can you try with non-DIAGNOSTIC
> > kernel and s/def DIAGNOSTIC/ 1/
> Done.  The resulting kernel boots properly.
>
> It would appear that the read enabled by the modification is necessary
> for proper operation.  Odd.  Cache interaction?
Maybe the chip just needs longer to sort itself out.

For now I think I'm going to commit this diff and someone with a

datasheet / more clue can fix it properly


OK?

Nick

Index: sys/arch/arm/omap/am335x_prcm.c
===================================================================
RCS file: /cvsroot/src/sys/arch/arm/omap/am335x_prcm.c,v
retrieving revision 1.9
diff -u -p -r1.9 am335x_prcm.c
--- sys/arch/arm/omap/am335x_prcm.c	18 Oct 2016 15:10:35 -0000	1.9
+++ sys/arch/arm/omap/am335x_prcm.c	23 Aug 2017 06:45:57 -0000
@@ -61,18 +61,12 @@ static void
 am335x_prcm_check_clkctrl(bus_size_t cm_module,
     bus_size_t clkctrl_reg, uint32_t v)
 {
-#ifdef DIAGNOSTIC
 	uint32_t u = prcm_read_4(cm_module, clkctrl_reg);
 
 	if (__SHIFTOUT(u, AM335X_CLKCTRL_MODULEMODE_MASK) !=
 	    __SHIFTOUT(v, AM335X_CLKCTRL_MODULEMODE_MASK))
 		aprint_error("clkctrl didn't take: %"PRIx32" -/-> %"PRIx32"\n",
 		    u, v);
-#else
-	(void)cm_module;
-	(void)clkctrl_reg;
-	(void)v;
-#endif
 }
 
 void