Subject: Re: Xarm32VIDC Problem?
To: Dave Daniels <dave_daniels@argonet.co.uk>
From: Richard Earnshaw <rearnsha@buzzard.freeserve.co.uk>
List: port-arm32
Date: 02/22/2001 21:59:07
This is a multipart MIME message.
--==_Exmh_8411004840
Content-Type: text/plain; charset=us-ascii
Here's another place where we aren't restoring the spl level after an
error.
Again, found by inspection rather than by testing...
--==_Exmh_8411004840
Content-Type: application/x-patch ; name="kbd.patch"
Content-Description: kbd.patch
Content-Disposition: attachment; filename="kbd.patch"
Index: kbd.c
===================================================================
RCS file: /cvsroot/syssrc/sys/arch/arm32/dev/kbd.c,v
retrieving revision 1.25
diff -p -p -r1.25 kbd.c
*** kbd.c 2000/03/23 06:35:14 1.25
--- kbd.c 2001/02/22 21:58:29
*************** kbdpoll(dev, events, p)
*** 332,339 ****
int revents = 0;
int s = spltty();
! if (KBDFLAG(dev) == KBDFLAG_CONUNIT)
return(ENXIO);
if (events & (POLLIN | POLLRDNORM)) {
if (sc->sc_q.c_cc > 0)
--- 332,341 ----
int revents = 0;
int s = spltty();
! if (KBDFLAG(dev) == KBDFLAG_CONUNIT) {
! splx(s);
return(ENXIO);
+ }
if (events & (POLLIN | POLLRDNORM)) {
if (sc->sc_q.c_cc > 0)
--==_Exmh_8411004840--