Subject: Re: Minor performance tweak to bcopy_page.S
To: None <rearnsha@buzzard.freeserve.co.uk, port-arm32@netbsd.org>
From: Ben Harris <bjh21@netbsd.org>
List: port-arm32
Date: 03/08/2001 14:19:01
In article <200103072138.f27LbJ500804@buzzard.freeserve.co.uk> you write:
>Unless folks don't want them here, I'll post some of my performance tweaks
>that I've made over the next few days. Folks are free to criticise or add
>them to the master sources as they see fit. Things are changing so
>rapidly at the moment that it is costing me serious amounts of time trying
>to keep these in sync with the master sources.
One thing I've noticed is that two of your changes have #ifdefs to
turn them off again. Do you think these are likely to be necessary?
It seems to me that if the changes are likely to have an adverse
effect on some systems, we should either detect those systems at
run-time, or not apply the changes at all. Having random undocumented
#ifdefs all over the place (without even a defopt, usually) is one of
the things that makes modifying the arm32 sources painful.
>This patch is a minor tweak to arm/arm32/bcopy_page.S.
Out of curiosity (I've not looked at the code) is there a good reason
for not using memcpy() here?
--
Ben Harris <bjh21@netbsd.org>
Portmaster, NetBSD/arm26 <URL:http://www.netbsd.org/Ports/arm26/>