Hi Leo,

Leo Weppelman wrote:
> Hi Leo....uhm...Matthias ;-)

you don't know how often I try to log into cvs.netbsd.org as leo... :-)

> On Tue 11 Aug 1998, Matthias Pfaller wrote:
> > In article <199808102131.WAA24545@aire.ncl.ac.uk>,
> > 	J.D.Coleman@newcastle.ac.uk (Julian Coleman) writes:
> > > Aha!  I've just read the notes in ncr5380.doc.  I was wondering if th=
ere
> > > was something different in the MI code that didn't display the problem
> > > with the se code.
> >=20
> > I'm just poking around in the dark, but sys/arch/atari/dev/ncr5380.c
> > uses command_size() in information_transfer to determine the size of the
> > SCSI command (and not like sys/dev/ic/ncr5380sbc.c xs->cmdlen). The
> > EA41x's receive command is a *one byte* command. I think the atari code
> > would think that this command is 12 bytes long... I don't know if this
> > would hurt.
>=20
> You might have a point of failure here. As a temporary workaround the pie=
ce
> of code in information_transfer() might be changed to read:
>        case PH_CMD :
>             if (reqp->xcmd.opcode =3D=3D REQUEST_SENSE)
>                 /* Probably 12, but I'm too lazy to look it up ;-) */
> 		len =3D command_size(reqp->xcmd.opcode);
> 	    else len =3D reqp->xs->cmdlen;
>             transfer_pio(&phase, (u_char *)&reqp->xcmd, &len, 0);
>             ......

I'm curious if this really was causing the problems. I compiled a more rece=
nt
-current kernel for my test machine last night. After work I'll try if my
EA412 is still working with this kernel (just in case it's a mi bug).

> Side note:
>   The sbc code is a bit strange wrt. sense commands either! Around line
> 2027 in ncr5380sbc.c, the check 'if (len !=3D xs->cmdlen)' looks suspicio=
us
> in the 'if (sr->sr_flags & SR_SENSE)' case.....

You are right. I think there is a bug lurking in the dark here...

Matthias
--=20
Matthias Pfaller                            Software Entwicklung
marco Systemanalyse und Entwicklung GmbH    Tel   +49 8131 5161-41
Hans-B=F6ckler-Str. 2, D 85221 Dachau         Fax   +49 8131 5161-66
http://www.marco.de/                        Email leo@dachau.marco.de