Re: Fixing md_root.c to unbusy bp buffer

[David Brownlee <abs%NetBSD.org@localhost>]

On Mon, 3 Nov 2008, T. Makinen wrote:

> It seems, that adding brelse(bp, 0) in md_root..c to unbusy bp buffer after
> biowait() fixes md2a device problems.
>
> Could you try current kernel with this patch:
> http://koti.welho.com/tmakinen/atari/netbsd-current-atari-BOOT-20081103.gz
>
> --- md_root.c.orig      2008-11-03 21:32:43.000000000 +0200
> +++ md_root.c   2008-11-03 23:27:11.000000000 +0200
> @@ -247,6 +247,8 @@
>                        printf("\n");
>
>                done = bp->b_bcount - bp->b_resid;
> +               brelse(bp, 0);
> +
>                bytes_left   -= done;
>                rsp->offset  += done;
>                rsp->bufp    += done;
> @@ -324,6 +326,8 @@
>                        printf("\n");
>
>                done = bp->b_bcount - bp->b_resid;
> +               brelse(bp, 0);
> +
>                nbyte        -= done;
>                nread        += done;
>                rsp->offset  += done;

        Excellent! Committing to current & requesting pullups now.

        With this fix does the system still need fd0a rather than
        md{0,1,2}a?

        So Tuomo, have you considered becoming a NetBSD developer? :)


--
                David/absolute       -- www.NetBSD.org: No hype required --