Re: oops, fixed diff

[Garrett D'Amore <garrett_damore%tadpole.com@localhost>]

Chris Gilbert wrote:
> As Nick's tested it, and it seems ok, I'm happy in terms of functionality.
>  My cats (well computer ones) haven't been powered up yet, as I moved
> house a month or so ago, and just haven't had time (partly due to having
> real cats :)
>
> However to be minorly picky on the diff, your:
> +#define      __HAVE_TIMECOUNTER
> uses a Tab, not a space after define (the defines above use space,
> although I've no idea which one is "the NetBSD" way)
>   

It probably isn't even worth fixing this.  I hope to remove the define
and make it implicit in the next month or so.  Along with GENERIC_TODR,
and maybe eventually GENERIC_SOFTINR. :-)

> (Although I shouldn't complain, given how little time I've had for the
> netbsd of late *sigh*)
>
> And you've nicely pre-empted my other comment which was for the KNF/ANSI
> thing to be done seperately  (I really should do the whole port at some
> point) So the change has more signal in it than noise :)
>
> Where does timer 3 get setup?  IE what hz is it running at, or is a
> default value assumed?  it used to be set in calibrate_timer, but no
> longer is.  (sorry I don't have the datasheet to hand)
>   

It is let run "free", and runs at dc21285_fclk.  This is still set up in
calibrate_timer, but it is implied since that is the behavior when only
the enable bit is set.

As you can guess, I have a datasheet (forwarded to me by someone else).

> Other than that I'm happy with it, so please go-ahead and check it in.
>   

Thanks.

    -- Garrett

> Thanks,
> Chris
>
>
> On Mon, September 11, 2006 7:47 am, Garrett D'Amore wrote:
>   
>> Thank for testing it Nick.
>>
>> At this point all I need is a go-ahead from either of the portmasters,
>> and I'll commit.
>>
>>     -- Garrett
>>
>> Nick Hudson wrote:
>>     
>>> On Monday 11 September 2006 06:47, Garrett D'Amore wrote:
>>>
>>>       
>>>> My last diff for footbridge tc was botched.  Thanks to Matt Thomas for
>>>> pointing out my error.  Again, this isn't tested yet, but it has a
>>>> better chance of not panic'ing.  :-)
>>>>
>>>>         
>>> For the record my CATS gives:
>>>
>>> $ sysctl kern.timecounter
>>> kern.timecounter.choice = dc21285_fclk(q=100, f=50000000 Hz)
>>> clockinterrupt(q=0, f=100 Hz) dummy(q=-1000000, f=1000000 Hz)
>>> kern.timecounter.hardware = dc21285_fclk
>>> kern.timecounter.timestepwarnings = 0
>>> $
>>> $ date; time sleep 10; date
>>> Mon Sep 11 06:10:56 UTC 2006
>>>    10.03s real     0.00s user     0.03s system
>>> Mon Sep 11 06:11:06 UTC 2006
>>>
>>> and regress/sys/kern/time ends with
>>>
>>> TEST SUCCESSFUL
>>>
>>> Nick
>>>
>>>       
>> --
>> Garrett D'Amore, Principal Software Engineer
>> Tadpole Computer / Computing Technologies Division,
>> General Dynamics C4 Systems
>> http://www.tadpolecomputer.com/
>> Phone: 951 325-2134  Fax: 951 325-2191
>>
>>     


-- 
Garrett D'Amore, Principal Software Engineer
Tadpole Computer / Computing Technologies Division,
General Dynamics C4 Systems
http://www.tadpolecomputer.com/
Phone: 951 325-2134  Fax: 951 325-2191