Subject: Re: build aborts in regress/lib/libpthread/sem
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
From: Marcus Comstedt <marcus@mc.pp.se>
List: port-dreamcast
Date: 02/21/2003 21:35:03
Izumi Tsutsui <tsutsui@ceres.dti.ne.jp> writes:

> Well, it was in my local sources..
> (of cource it could be removed, though)

If it's useful to do it like that, then I'd suggest we go with Jason's
variant instead, where the variable is a parameter to the macros.  But
I'm still a bit puzzled why you'd want the critical section to span
the beginning and end of the loop, but not the middle.  What does the
actual code look like?


> In my humble opinion, it isn't a good idea to use
> such a bit ugly trick in macro which is introduced
> to hide 'excessive cut'n'paste.' ;-)

At least the uglyness would be confined to one place, rather than
being sprinkled out through the code.  The key to maintainability is
to make the majority of the code clean and simple, even if it means
having a very small portion that's all the more convoluted.
At least, that's what _I_ think.  :-)


  // Marcus