Subject: X11 server patch
To: None <port-hp300@sun-lamp.cs.berkeley.edu>
From: jason downs <downsj@CSOS.ORST.EDU>
List: port-hp300
Date: 08/10/1994 20:36:16
patch for server/ddx/hpbsd/topcat/tcFillRct.c

if pixmap is NULL, you really shouldn't dereference it.

(this patch prevents 'xman' from crashing the server.)

*** tcFillRct.c.orig	Wed Aug 10 19:51:00 1994
--- tcFillRct.c	Wed Aug 10 19:58:05 1994
***************
*** 252,258 ****
  	if (!((cfbPrivGCPtr) pGC->devPrivates[cfbGCPrivateIndex].ptr)->
  							pRotatedPixmap)
  	{
! 	    if (onScreen && pGC->tile.pixmap->devKind == PIXMAP_FRAME_BUFFER)
  		BoxFill = tcFillRectTile;
  	    else
  		BoxFill = cfbFillRectTileOdd;
--- 252,259 ----
  	if (!((cfbPrivGCPtr) pGC->devPrivates[cfbGCPrivateIndex].ptr)->
  							pRotatedPixmap)
  	{
! 	    if (onScreen && pGC->tile.pixmap
! 		&& (pGC->tile.pixmap->devKind == PIXMAP_FRAME_BUFFER))
  		BoxFill = tcFillRectTile;
  	    else
  		BoxFill = cfbFillRectTileOdd;

--
                    ----------------------------------------
-------------------// jason downs // downsj@CSOS.ORST.EDU //------------------
                   ----------------------------------------      JD105
		  http://www.CSOS.ORST.EDU/downsj/index.html
		       have you fed your sysadmin today?

------------------------------------------------------------------------------