Subject: Re: ac97 and suspend/resume on laptops
To: Love <lha@stacken.kth.se>
From: Joachim Thiemann <thiemann@gel.usherbrooke.ca>
List: port-i386
Date: 07/15/2004 20:59:27
On Thursday 15 July 2004 16:07, Love wrote:
> I think the codec isn't ready. With this patch, my IBM T30 (with same
> chipset as you have) plays sounds just fine after resume. I also used
> include the dont restore reset reg part of your ac97 patch, unclear if
> that is really needed.
I just tested that with unmodified ac97.c and it does seem to work. Thanks!
Certainly seems cleaner than my patch. But yeah, I think preventing
restore_shadow from writing to the reset register is still a good idea.
Did you send this as a PR yet? it sems to be a good idea to have it in
2.0...
Joe.
--
http://www.gel.usherbrooke.ca/thiemann