Re: Intel DG43NB (G43 & ICH10) interrupt storm

[Brad du Plessis <bradd%cat.co.za@localhost>]

Christos Zoulas wrote:
> In article <48E2374F.9060709%cat.co.za@localhost>,
> Brad du Plessis  <bradd%cat.co.za@localhost> wrote:
>   
> > Some more information here that may be of interest:
> >
> > I've hacked these vendor/product ID's:
> >
> > pcib0: vendor 0x8086 product 0x3a18 (rev. 0x00)
> > pciide0: vendor 0x8086 product 0x3a20 (rev. 0x00)
> > pciide1: vendor 0x8086 product 0x3a26 (rev. 0x00)
> >
> > into the piixide(4) driver.
> >
> >
> >
> >
> > And I hacked this:
> >
> > vendor 0x8086 product 0x3a30 (SMBus serial bus) at pci0 dev 31 function 
> > 3 not configured
> >
> > into the ichsmb(4) driver.
> >
> > Now my interrupt storm has gone. What I did doesn't feel very safe :) , 
> > but it seems to have solved my immediate problem. Anyone foresee any 
> > issues with this?
> >     
>
> Send a patch?

Please excuse my naming in pcidevs.h, I'm not quite sure about the 
naming conventions.

Index: ichsmb.c
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/ichsmb.c,v
retrieving revision 1.16
diff -u -r1.16 ichsmb.c
--- ichsmb.c    8 Sep 2008 20:49:41 -0000    1.16
+++ ichsmb.c    1 Oct 2008 06:28:35 -0000
@@ -104,6 +104,7 @@
        case PCI_PRODUCT_INTEL_82801G_SMB:
        case PCI_PRODUCT_INTEL_82801H_SMB:
        case PCI_PRODUCT_INTEL_82801I_SMB:
+        case PCI_PRODUCT_INTEL_82801I_SMB_ICH10:
            return 1;
        }
    }
Index: pcidevs.h
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/pcidevs.h,v
retrieving revision 1.959
diff -u -r1.959 pcidevs.h
--- pcidevs.h    28 Sep 2008 11:36:06 -0000    1.959
+++ pcidevs.h    1 Oct 2008 06:28:37 -0000
@@ -2214,6 +2214,7 @@
#define    PCI_PRODUCT_INTEL_82801I_IFE_GT    0x10c3        /* 82801I 
(GT) LAN Controller */
#define    PCI_PRODUCT_INTEL_82801H_IFE_GT    0x10c4        /* i82801H 
IFE (GT) LAN Controller */
#define    PCI_PRODUCT_INTEL_82801H_IFE_G    0x10c5        /* i82801H 
IFE (G) LAN Controller */
+#define    PCI_PRODUCT_INTEL_82567V 0x10ce /* i82567V LAN controller */
#define    PCI_PRODUCT_INTEL_82815_DC100_HUB    0x1100        /* 82815 
Hub */
#define    PCI_PRODUCT_INTEL_82815_DC100_AGP    0x1101        /* 82815 
AGP */
#define    PCI_PRODUCT_INTEL_82815_DC100_GRAPH    0x1102        /* 
82815 Graphics */
@@ -2493,6 +2494,9 @@
#define    PCI_PRODUCT_INTEL_82801H_HDA    0x284b        /* 82801H High 
Definition Audio Controller */
#define    PCI_PRODUCT_INTEL_82801H_THERMAL    0x284f        /* 82801H 
Thermal Controller */
#define    PCI_PRODUCT_INTEL_82801IH_LPC    0x2912        /* 82801IH 
LPC Interface Bridge */
+#define    PCI_PRODUCT_INTEL_82801I_ICH10            0x3a18 /* BRAD */
+#define    PCI_PRODUCT_INTEL_82801I_ICH10_SATA_1    0x3a20
+#define    PCI_PRODUCT_INTEL_82801I_ICH10_SATA_2    0x3a26
#define    PCI_PRODUCT_INTEL_82801IO_LPC    0x2914        /* 82801IO 
LPC Interface Bridge */
#define    PCI_PRODUCT_INTEL_82801IR_LPC    0x2916        /* 82801IR 
LPC Interface Bridge */
#define    PCI_PRODUCT_INTEL_82801IB_LPC    0x2918        /* 82801IB 
LPC Interface Bridge */
@@ -2502,6 +2506,7 @@
#define    PCI_PRODUCT_INTEL_82801I_SATA_AHCI4    0x2923        /* 
82801I AHCI SATA Controller with 4 ports */
#define    PCI_PRODUCT_INTEL_82801I_SATA_3    0x2926        /* 82801I 
SATA Controller with 2 ports */
#define    PCI_PRODUCT_INTEL_82801I_SMB    0x2930        /* 82801I 
SMBus Controller */
+#define    PCI_PRODUCT_INTEL_82801I_SMB_ICH10    0x3a30        /* BRAD 
82801I SMBus Controller */
#define    PCI_PRODUCT_INTEL_82801I_THERMAL    0x2932        /* 82801I 
Thermal Controller */
#define    PCI_PRODUCT_INTEL_82801I_USB_1    0x2934        /* 82801I 
USB UHCI Controller */
#define    PCI_PRODUCT_INTEL_82801I_USB_2    0x2935        /* 82801I 
USB UHCI Controller */
Index: piixide.c
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/piixide.c,v
retrieving revision 1.46
diff -u -r1.46 piixide.c
--- piixide.c    18 Mar 2008 20:46:37 -0000    1.46
+++ piixide.c    1 Oct 2008 06:28:37 -0000
@@ -246,6 +246,24 @@
      "Intel 631xESB/632xESB Serial ATA Controller",
      piixsata_chip_map,
    },
+    { PCI_PRODUCT_INTEL_82801I_ICH10,
+      0,
+      "Intel 82801I Serial ATA Controller (ICH10)",
+      piixsata_chip_map,
+    },
+
+    { PCI_PRODUCT_INTEL_82801I_ICH10_SATA_1,
+      0,
+      "Intel 82801I Serial ATA Controller (SATA 1, ICH10)",
+      piixsata_chip_map,
+    },
+
+    { PCI_PRODUCT_INTEL_82801I_ICH10_SATA_2,
+      0,
+      "Intel 82801I Serial ATA Controller (SATA 2, ICH10)",
+      piixsata_chip_map,
+    },
+
    { 0,
      0,
      NULL,