On 01/18/11 20:05, Jukka Ruohonen wrote:
On Tue, Jan 18, 2011 at 07:58:05PM +0000, Matthias Scheler wrote:ACPI was first release in 1996 which means that e.g. 1985 wouldn't be valid release date. From that point of view the value should be 96.
Should we care? I think it's clearer to the reader if the code says 70 (i.e. the epoch) instead of a seemingly-random value. We are not going to hit those cases anyway...
But at this point, if the value should change I would like to see consensus first -- not like this morning.
The rationale of this change was to explicitly prevent these old systems from loading ACPI. This way majority of the hard BIOS bugs can be ruled out. With this change we follow Microsoft (ACPI was enabled by default in Windows XP) and Linux (ACPI is disabled for systems that have been manufactured before Windows XP).
Old systems are ruled out by the ACPI_BLACKLIST_YEAR definition, which is checked somewhere else.