Re: RFC: cpu microcode loading support

[David Young <dyoung%pobox.com@localhost>]

On Fri, Dec 16, 2011 at 04:17:50PM +0100, Christoph Egger wrote:
> Index: sys/arch/amd64/include/types.h
> ===================================================================
> RCS file: /cvsroot/src/sys/arch/amd64/include/types.h,v
> retrieving revision 1.40
> diff -u -p -r1.40 types.h
> --- sys/arch/amd64/include/types.h    4 Dec 2011 16:24:13 -0000       1.40
> +++ sys/arch/amd64/include/types.h    16 Dec 2011 15:07:02 -0000
> @@ -108,4 +108,10 @@ typedef  volatile unsigned char          __cpu_si
>  
>  #endif       /*      __x86_64__      */
>  
> +#if defined(XEN) && defined(DOM0OPS)
> +#define __HAVE_CPU_MICROCODE
> +#elif !defined(XEN)
> +#define __HAVE_CPU_MICROCODE
> +#endif
> +
>  #endif       /* _X86_64_MACHTYPES_H_ */

As a general rule, I object to configuring the kernel with #defines.  I
think that you can use the linker here.

Dave

-- 
David Young
dyoung%pobox.com@localhost    Urbana, IL    (217) 721-9981