Re: VMware VMXNET3 driver

[Fredrik Pettai <pettai%nordu.net@localhost>]

On Jun 18, 2014, at 11:17 , Fredrik Pettai <pettai%nordu.net@localhost> wrote:
> On Jun 9, 2014, at 13:29 , Hikaru Abe <hikaru.abe%gmail.com@localhost> wrote:
>> Hi
>> 
>> I'm porting the vmx(4) driver from OpenBSD.
>> Is this ok to commit?
>> 
>> http://www.netbsd.org/~hikaru/vmxnet3.patch
> 
> It would be nice if this could be backported to netbsd-6 as well. 
> 
> Does sys/dev/pci/if_vmx.c & sys/dev/pci/if_vmxreg.h need any adjustments for 
> netbsd-6 ?
> If not, I'll make a pull-up request...

Although the patch applied almost flawlessly to the netbsd-6 source, it seems 
to need some modifications before it's able to be built for netbsd-6…

[…]
#   compile  GENERIC/if_vmx.o
/usr/src/../tools/bin/i486--netbsdelf-gcc -mno-sse -mno-sse2 -mno-sse3 
-ffreestanding -fno-zero-initialized-in-bss -O2 -fstack-protector 
-Wstack-protector --param ssp-buffer-size=1 -fno-strict-aliasing -std=gnu99 
-Werror -Wall -Wno-main -Wno-format-zero-length -Wpointer-arith 
-Wmissing-prototypes -Wstrict-prototypes -Wold-style-definition -Wswitch 
-Wshadow -Wcast-qual -Wwrite-strings -Wno-unreachable-code -Wno-pointer-sign 
-Wno-attributes -Wextra -Wno-unused-parameter -Wold-style-definition 
-Wno-sign-compare --sysroot=/usr/src/../obj/destdir.i386 -Di386 -I. 
-I/usr/src/sys/../common/include -I/usr/src/sys/arch -I/usr/src/sys -nostdinc 
-DMAXUSERS=64 -D_KERNEL -D_KERNEL_OPT -std=gnu99 
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/quad 
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/string 
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/arch/i386/string 
-I/usr/src/sys/dist/ipf -I/usr/src/sys/external/isc/atheros_hal/dist 
-I/usr/src/sys/external/isc/atheros_hal/ic 
-I/usr/src/sys/external/bsd/drm/dist/bsd-core 
-I/usr/src/sys/external/bsd/drm/dist/shared-core 
-I/usr/src/sys/../common/include 
-I/usr/src/sys/external/bsd/acpica/dist/include -c /usr/src/sys/dev/pci/if_vmx.c
In file included from /usr/src/sys/dev/pci/if_vmx.c:34:0:
/usr/src/sys/netinet/if_inarp.h:48:19: error: field 'sin_addr' has incomplete 
type
/usr/src/sys/netinet/if_inarp.h:49:19: error: field 'sin_srcaddr' has 
incomplete type
/usr/src/sys/dev/pci/if_vmx.c: In function 'vmxnet3_match':
/usr/src/sys/dev/pci/if_vmx.c:183:32: error: 'PCI_PRODUCT_VMWARE_VMXNET3' 
undeclared (first use in this function)
/usr/src/sys/dev/pci/if_vmx.c:183:32: note: each undeclared identifier is 
reported only once for each function it appears in
/usr/src/sys/dev/pci/if_vmx.c: In function 'vmxnet3_attach':
/usr/src/sys/dev/pci/if_vmx.c:201:15: error: 'PCI_INTRSTR_LEN' undeclared 
(first use in this function)
/usr/src/sys/dev/pci/if_vmx.c:250:2: error: too many arguments to function 
'pci_intr_string'
./x86/pci_machdep_common.h:107:13: note: declared here
cc1: warnings being treated as errors
/usr/src/sys/dev/pci/if_vmx.c:201:7: error: unused variable 'intrbuf'

*** Failed target:  if_vmx.o
*** Failed command: echo '# ' "compile GENERIC/if_vmx.o" && echo 
/usr/src/../tools/bin/i486--netbsdelf-gcc -mno-sse -mno-sse2 -mno-sse3 
-ffreestanding -fno-zero-initialized-in-bss -O2 -fstack-protector 
-Wstack-protector --param ssp-buffer-size=1 -fno-strict-aliasing -std=gnu99 
-Werror -Wall -Wno-main -Wno-format-zero-length -Wpointer-arith 
-Wmissing-prototypes -Wstrict-prototypes -Wold-style-definition -Wswitch 
-Wshadow -Wcast-qual -Wwrite-strings -Wno-unreachable-code -Wno-pointer-sign 
-Wno-attributes -Wextra -Wno-unused-parameter -Wold-style-definition 
-Wno-sign-compare --sysroot=/usr/src/../obj/destdir.i386 -Di386 -I. 
-I/usr/src/sys/../common/include -I/usr/src/sys/arch -I/usr/src/sys -nostdinc 
-DMAXUSERS=64 -D_KERNEL -D_KERNEL_OPT -std=gnu99 
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/quad 
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/string 
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/arch/i386/string 
-I/usr/src/sys/dist/ipf -I/usr/src/sys/external/isc/atheros_hal/dist 
-I/usr/src/sys/external/isc/atheros_hal/ic 
-I/usr/src/sys/external/bsd/drm/dist/bsd-core 
-I/usr/src/sys/external/bsd/drm/dist/shared-core 
-I/usr/src/sys/../common/include 
-I/usr/src/sys/external/bsd/acpica/dist/include -c 
/usr/src/sys/dev/pci/if_vmx.c && /usr/src/../tools/bin/i486--netbsdelf-gcc 
-mno-sse -mno-sse2 -mno-sse3 -ffreestanding -fno-zero-initialized-in-bss -O2 
-fstack-protector -Wstack-protector --param ssp-buffer-size=1 
-fno-strict-aliasing -std=gnu99 -Werror -Wall -Wno-main -Wno-format-zero-length 
-Wpointer-arith -Wmissing-prototypes -Wstrict-prototypes -Wold-style-definition 
-Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wno-unreachable-code 
-Wno-pointer-sign -Wno-attributes -Wextra -Wno-unused-parameter 
-Wold-style-definition -Wno-sign-compare --sysroot=/usr/src/../obj/destdir.i386 
-Di386 -I. -I/usr/src/sys/../common/include -I/usr/src/sys/arch -I/usr/src/sys 
-nostdinc -DMAXUSERS=64 -D_KERNEL -D_KERNEL_OPT -std=gnu99 
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/quad 
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/string 
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/arch/i386/string 
-I/usr/src/sys/dist/ipf -I/usr/src/sys/external/isc/atheros_hal/dist 
-I/usr/src/sys/external/isc/atheros_hal/ic 
-I/usr/src/sys/external/bsd/drm/dist/bsd-core 
-I/usr/src/sys/external/bsd/drm/dist/shared-core 
-I/usr/src/sys/../common/include 
-I/usr/src/sys/external/bsd/acpica/dist/include -c 
/usr/src/sys/dev/pci/if_vmx.c && echo
*** Error code 1

Stop.
nbmake: stopped in /usr/obj/sys/arch/i386/compile/GENERIC

ERROR: Failed to make all in "/usr/src/../obj/sys/arch/i386/compile/GENERIC"
*** BUILD ABORTED ***