Subject: Re: loadelf_32.c: code review request: was=>Re: ia64 unwind section: Loader implementation
To: Christos Zoulas <christos@astron.com>
From: Cherry G. Mathew <cherry.g.mathew@gmail.com>
List: port-ia64
Date: 04/04/2006 11:38:44
On 4/3/06, Christos Zoulas <christos@astron.com> wrote:
> In article <A23ABE43-CFE0-476E-8663-991A757ABF7F@3am-software.com>,
> Matt Thomas  <matt@3am-software.com> wrote:
> >
> >On Apr 1, 2006, at 11:13 AM, Cherry G. Mathew wrote:
> >
> >> +                 MD_LOADSEG(phdr[i]))
> >
> >You should be passing &phdr[i] so that if MD_LOADSEG results in
> >a function call you are passing by reference.
>
> I've been thinking exactly the same thing :-)
>
> christos
>
>

Sounds reasonable to me.
Lets hold on to this for the moment for more comments, if any.

--
~Cherry