Subject: Re: DUOTEST kernel
To: Daishi Kato <daishi@axlight.com>
From: Bill Studenmund <wrstuden@nas.nasa.gov>
List: port-mac68k
Date: 10/28/1999 17:22:42
Thanks for the patches!
A few minor points:
On Fri, 29 Oct 1999, Daishi Kato wrote:
> --- mac68k/machdep.c.orig Tue Oct 26 22:45:10 1999
> +++ mac68k/machdep.c Thu Oct 28 21:57:16 1999
> @@ -2513,7 +2513,7 @@
> {
> u_long addr, phys;
>
> - if (!get_physical(videoaddr, &phys))
> + if (!get_physical(videoaddr, &phys)&&!(phys=videoaddr)) /*by daishi*/
^
That's not right. :-)
That will always assign videoaddr to phys, and succeed if videoaddr is
non-zero.
If that's what you really want to, please code it more explicitly. :-)
> printf("get_mapping(): %s. False start.\n", id);
> else {
> mac68k_vidlog = videoaddr;
My only other concern is could you code them some way that one kernel
could boot both on a duo and a non-duo machine? We already have a 2x2
matrix of kernels (sbc vs ncr scsi, mrg vs hw-direct adb) and I think it'd
be saner for everyone if we didn't make it 2x2x2. :-)
Thanks!
Take care,
Bill