Port-macppc archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: port-macppc/39176



Some comments with respect to the patch:
 I think that the following lines in kauai.c (rev. 1.25):
58 #define PIO_CONFIG_REG (0x200 >> 4) /* PIO and DMA access timing */
    59 #define DMA_CONFIG_REG (0x210 >> 4)        /* UDMA access timing */
should read instead:
    58 #define PIO_CONFIG_REG   0x200  /* PIO and DMA access timing */
    59 #define DMA_CONFIG_REG  0x210 /* UDMA access timing */

Sounds very plausible, I remember making similar changes at lots of other places when bus_space-ifying kauai.c, guess I missed that one.

Home | Main Index | Thread Index | Old Index