Subject: clone() fix pullup
To: None <cgd@netbsd.org>
From: Matthias Drochner <M.Drochner@fz-juelich.de>
List: port-mips
Date: 10/31/2003 18:11:02
Hi -
can the fix to lib/libc/arch/mips/sys/__clone.S:
revision 1.5
date: 2003/02/08 00:28:25; author: cgd; state: Exp; lines: +12 -7
* fix handling of invalid arguments (was jumping to wrong label!)
(found by... running the regress test!)
* clean up punctuation.
* create a proper frame for the child fn that follows the o32 calling
conventions. In particular, leave 4 stack slots that the child
fn can write on, put the GP above them, and invoke .cprestore
properly in light of the child fn arg area. (realized it was a
problem upon inspection, verified using the regress test compiled
-O0.)
be pulled up to 1.6 in its entirety?
Well, very likely it can, but all my mips boxes are -current or close
to it, so I can't test myself.
There is PR port-mips/20657 referring to this failure in 1.6,
it contains a patch which just fixes the jump label.
best regards
Matthias