Subject: Re: MIPS bus_space macros vs functions
To: None <simonb@wasabisystems.com>
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
List: port-mips
Date: 11/26/2005 01:08:02
In article <20051125140640.GA25276@thoreau.thistledown.com.au>
simonb@wasabisystems.com wrote:
> (which uses bus_space functions in it's ethernet driver) before took:
>
> 350.520u 44.351s 6:58.84 94.2% 0+0k 0+0io 185pf+0w
> 349.663u 44.458s 6:59.13 94.0% 0+0k 0+0io 7pf+0w
> 349.797u 44.109s 6:56.85 94.4% 0+0k 0+0io 7pf+0w
>
> and after took:
>
> 351.099u 44.318s 6:58.40 94.5% 0+0k 0+0io 112pf+0w
> 351.480u 43.919s 6:57.58 94.6% 0+0k 0+0io 7pf+0w
> 351.205u 44.174s 6:54.45 95.3% 0+0k 0+0io 7pf+0w
>
> So we've saved about 35kB of text for one kernel, about 12kB for another
> and any performance changes are statistical noise.
The %U and %P look a bit different? (just curious :-)
> I can't think of a reason not to apply this patch. Can anyone else?
It's better to handle PR port-mips/31910 first?
(I have not check it yet though)
---
Izumi Tsutsui